From 03a9c6649bc9cbb8279cc105099fb7ccb7f630e2 Mon Sep 17 00:00:00 2001 From: Karsten Blees Date: Sat, 9 May 2015 00:05:11 +0200 Subject: [PATCH] fixup! mingw: Support `git_terminal_prompt` with more terminals Move 'close(child.out)' down. Signed-off-by: Karsten Blees --- compat/terminal.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/compat/terminal.c b/compat/terminal.c index 2842fe7429..025960d80e 100644 --- a/compat/terminal.c +++ b/compat/terminal.c @@ -124,14 +124,12 @@ static char *xterm_prompt(const char *prompt, int echo) if (write_in_full(child.in, prompt, prompt_len) != prompt_len) { error("Could not write to xterm"); close(child.in); - close(child.out); goto ret; } close(child.in); strbuf_reset(&buffer); len = strbuf_read(&buffer, child.out, 1024); - close(child.out); if (len < 0) { error("Could not read from xterm"); goto ret; @@ -141,6 +139,7 @@ static char *xterm_prompt(const char *prompt, int echo) strbuf_strip_suffix(&buffer, "\r"); ret: + close(child.out); if (!code) finish_command(&child);