From 041903fa702da3a95ff1d76e8aba962f027b1ad8 Mon Sep 17 00:00:00 2001 From: Adrian Ratiu Date: Sun, 22 Feb 2026 02:28:55 +0200 Subject: [PATCH] repository: fix repo_init() memleak due to missing _clear() There is an old pre-existing memory leak in repo_init() due to failing to call clear_repository_format() in the error case. It went undetected because a specific bug is required to trigger it: enable a v1 extension in a repository with format v0. Obviously this can only happen in a development environment, so it does not trigger in normal usage, however the memleak is real and needs fixing. Fix it by also calling clear_repository_format() in the error case. Signed-off-by: Adrian Ratiu Signed-off-by: Junio C Hamano --- repository.c | 1 + 1 file changed, 1 insertion(+) diff --git a/repository.c b/repository.c index f27ab29b0e..78aa2d31d0 100644 --- a/repository.c +++ b/repository.c @@ -298,6 +298,7 @@ int repo_init(struct repository *repo, return 0; error: + clear_repository_format(&format); repo_clear(repo); return -1; }