mirror of
https://github.com/git/git.git
synced 2026-04-12 01:40:10 +02:00
ident: don't require calling prepare_fallback_ident first
In fd5a58477c ("ident: add the ability to provide a "fallback
identity"", 2019-02-25) I made it a requirement to call
prepare_fallback_ident as the first function in the ident API.
However in stash we didn't actually end up following that.
This leads to a BUG if user.email and user.name are set. It was not
caught in the test suite because we only rely on environment variables
for setting the user name and email instead of the config.
Instead of making it a bug to call other functions in the ident API
first, just return silently if the identity of a user was already set
up.
Reported-by: Denton Liu <liu.denton@gmail.com>
Helped-by: Jeff King <peff@peff.net>
Signed-off-by: Thomas Gummerer <t.gummerer@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
committed by
Junio C Hamano
parent
fd5a58477c
commit
0640897dc5
@@ -1096,6 +1096,12 @@ test_expect_success 'stash -- <subdir> works with binary files' '
|
||||
test_path_is_file subdir/untracked
|
||||
'
|
||||
|
||||
test_expect_success 'stash with user.name and user.email set works' '
|
||||
test_config user.name "A U Thor" &&
|
||||
test_config user.email "a.u@thor" &&
|
||||
git stash
|
||||
'
|
||||
|
||||
test_expect_success 'stash works when user.name and user.email are not set' '
|
||||
git reset &&
|
||||
>1 &&
|
||||
|
||||
Reference in New Issue
Block a user