global/git
1
0
Fork 0
mirror of https://github.com/git/git.git synced 2026-04-11 17:30:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

Replace unpack_entry_gently with unpack_entry.

Browse Source 
The unpack_entry_gently function currently has only two callers:
the delta base resolution in sha1_file.c and the main loop of
pack-check.c.  Both of these must change to using unpack_entry
directly when we implement sliding window mmap logic, so I'm doing
it earlier to help break down the change set.

This may cause a slight performance decrease for delta base
resolution as well as for pack-check.c's verify_packfile(), as
the pack use counter will be incremented and decremented for every
object that is unpacked.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:
Shawn O. Pearce
2006-12-23 02:33:25 -05:00
committed by Junio C Hamano
parent 1ed4813f7d
commit 4d703a1a90
3 changed files with 15 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pack-check.c
View File

@@ -51,7 +51,7 @@ static int verify_packfile(struct packed_git *p)
offset = find_pack_entry_one(sha1, p);
if (!offset)
die("internal error pack-check find-pack-entry-one");
data = unpack_entry_gently(p, offset, type, &size);
data = unpack_entry(p, offset, type, &size);
if (!data) {
err = error("cannot unpack %s from %s",
sha1_to_hex(sha1), p->pack_name);