From 56dc8fc47aa94fb74f824d8994f0b5340cd0228a Mon Sep 17 00:00:00 2001
From: Johannes Sixt <johannes.sixt@telecom.at>
Date: Tue, 25 Sep 2007 12:32:27 +0200
Subject: [PATCH] Fix fstat() implementation for pipes and sockets again.

It turns out that GetFileInformationByHandle() succeeds even for pipes
and sockets. Hence, we fall back to Windows's own fstat() implementation
for everything except files. This also takes care of any error codes
(again, except for files - but we don't expect any errors here).
---
 compat/mingw.c | 24 ++++++------------------
 1 file changed, 6 insertions(+), 18 deletions(-)

diff --git a/compat/mingw.c b/compat/mingw.c
index af522f1666..8bb0dba16c 100644
--- a/compat/mingw.c
+++ b/compat/mingw.c
@@ -116,17 +116,20 @@ int git_lstat(const char *file_name, struct stat *buf)
 	return do_lstat(alt_name, buf);
 }
 
+#undef fstat
 int git_fstat(int fd, struct stat *buf)
 {
 	HANDLE fh = (HANDLE)_get_osfhandle(fd);
 	BY_HANDLE_FILE_INFORMATION fdata;
-	char dummy[sizeof(void*)];
-	int s = sizeof(void*);
 
 	if (fh == INVALID_HANDLE_VALUE) {
 		errno = EBADF;
 		return -1;
 	}
+	/* direct non-file handles to MS's fstat() */
+	if (GetFileType(fh) != FILE_TYPE_DISK)
+		return fstat(fd, buf);
+
 	if (GetFileInformationByHandle(fh, &fdata)) {
 		int fMode = S_IREAD;
 		if (fdata.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY)
@@ -148,22 +151,7 @@ int git_fstat(int fd, struct stat *buf)
 		buf->st_ctime = filetime_to_time_t(&(fdata.ftCreationTime));
 		return 0;
 	}
-	switch (GetLastError()) {
-	case ERROR_INVALID_FUNCTION:
-		/* check for socket */
-		if (getsockopt((int)fh, SOL_SOCKET, SO_KEEPALIVE, dummy, &s) &&
-		    WSAGetLastError() == WSAENOTSOCK)
-			goto badf;
-		memset(buf, sizeof(*buf), 0);
-		buf->st_mode = S_IREAD|S_IWRITE;
-		buf->st_mode |= 0x140000; /* S_IFSOCK */
-		return 0;
-	default:
-	case ERROR_INVALID_HANDLE:
-	badf:
-		errno = EBADF;
-		break;
-	}
+	errno = EBADF;
 	return -1;
 }