global/git
1
0
Fork 0
mirror of https://github.com/git/git.git synced 2026-03-27 00:50:11 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'jk/rev-list-empty-input'

Browse Source 
"git log --tag=no-such-tag" showed log starting from HEAD, which
has been fixed---it now shows nothing.

* jk/rev-list-empty-input:
  revision: do not fallback to default when rev_input_given is set
  rev-list: don't show usage when we see empty ref patterns
  revision: add rev_input_given flag
  t6018: flesh out empty input/output rev-list tests
This commit is contained in:
Junio C Hamano
2017-08-11 13:27:07 -07:00
parent 9c1259a0da 5d34d1ac06
commit 8fbaf0b13b
5 changed files with 26 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
t/t4202-log.sh
View File

@@ -1523,6 +1523,12 @@ test_expect_success 'log diagnoses bogus HEAD' '
test_i18ngrep broken stderr
'
test_expect_success 'log does not default to HEAD when rev input is given' '
>expect &&
git log --branches=does-not-exist >actual &&
test_cmp expect actual
'
test_expect_success 'set up --source tests' '
git checkout --orphan source-a &&
test_commit one &&

20
t/t6018-rev-list-glob.sh
View File

@@ -255,27 +255,19 @@ test_expect_success 'rev-list accumulates multiple --exclude' '
compare rev-list "--exclude=refs/remotes/* --exclude=refs/tags/* --all" --branches
'
# "git rev-list<ENTER>" is likely to be a bug in the calling script and may
# deserve an error message, but do cases where set of refs programmatically
# given using globbing and/or --stdin need to fail with the same error, or
# are we better off reporting a success with no output? The following few
# tests document the current behaviour to remind us that we might want to
# think about this issue.
test_expect_failure 'rev-list may want to succeed with empty output on no input (1)' '
test_expect_failure 'rev-list should succeed with empty output on empty stdin' '
>expect &&
git rev-list --stdin <expect >actual &&
test_cmp expect actual
'
test_expect_failure 'rev-list may want to succeed with empty output on no input (2)' '
test_expect_success 'rev-list should succeed with empty output with all refs excluded' '
>expect &&
git rev-list --exclude=* --all >actual &&
test_cmp expect actual
'
test_expect_failure 'rev-list may want to succeed with empty output on no input (3)' '
test_expect_success 'rev-list should succeed with empty output with empty --all' '
(
test_create_repo empty &&
cd empty &&
@@ -285,6 +277,12 @@ test_expect_failure 'rev-list may want to succeed with empty output on no input
)
'
test_expect_success 'rev-list should succeed with empty output with empty glob' '
>expect &&
git rev-list --glob=does-not-match-anything >actual &&
test_cmp expect actual
'
test_expect_success 'shortlog accepts --glob/--tags/--remotes' '
compare shortlog "subspace/one subspace/two" --branches=subspace &&