global/git
1
0
Fork 0
mirror of https://github.com/git/git.git synced 2026-01-10 10:13:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

difftool: honor --trust-exit-code for builtin tools

Browse Source 
run_merge_tool() was not setting $status, which prevented the
exit code for builtin tools from being forwarded to the caller.

Capture the exit status and add a test to guarantee the behavior.

Reported-by: Adria Farres <14farresa@gmail.com>
Signed-off-by: David Aguilar <davvid@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
David Aguilar
2014-11-14 13:33:55 -08:00
committed by Junio C Hamano
parent 2b52123fcf
commit 99474b6340
2 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
git-mergetool--lib.sh
View File

@@ -221,6 +221,7 @@ run_merge_tool () {
else else
run_diff_cmd "$1" run_diff_cmd "$1"
fi fi
status=$?
return $status return $status
} }

5
t/t7800-difftool.sh
View File

@@ -86,6 +86,11 @@ test_expect_success PERL 'difftool forwards exit code with --trust-exit-code' '
test_must_fail git difftool -y --trust-exit-code -t error branch test_must_fail git difftool -y --trust-exit-code -t error branch
' '
test_expect_success PERL 'difftool forwards exit code with --trust-exit-code for built-ins' '
test_config difftool.vimdiff.path false &&
test_must_fail git difftool -y --trust-exit-code -t vimdiff branch
'
test_expect_success PERL 'difftool honors difftool.trustExitCode = true' ' test_expect_success PERL 'difftool honors difftool.trustExitCode = true' '
test_config difftool.error.cmd false && test_config difftool.error.cmd false &&
test_config difftool.trustExitCode true && test_config difftool.trustExitCode true &&