From 9b178ba84defc24e32168f903ee47f99a355f004 Mon Sep 17 00:00:00 2001 From: Alexander Sulfrian Date: Sun, 29 Aug 2010 17:13:15 +0200 Subject: [PATCH] daemon: add helper function setup_named_sock() Add setup_named_sock() as helper function for socksetup to make it easier to create more than one listen sockets. named_sock_setup can be called more than one time and add the new sockets to the supplied socklist_p. Signed-off-by: Alexander Sulfrian Signed-off-by: Junio C Hamano --- daemon.c | 35 ++++++++++++++++++++++++----------- 1 file changed, 24 insertions(+), 11 deletions(-) diff --git a/daemon.c b/daemon.c index e22a2b7fa5..deda4cf0a2 100644 --- a/daemon.c +++ b/daemon.c @@ -736,9 +736,9 @@ static int set_reuse_addr(int sockfd) #ifndef NO_IPV6 -static int socksetup(char *listen_addr, int listen_port, int **socklist_p) +static int setup_named_sock(char *listen_addr, int listen_port, int **socklist_p, int socknum) { - int socknum = 0, *socklist = NULL; + int *socklist = *socklist_p; int maxfd = -1; char pbuf[NI_MAXSERV]; struct addrinfo hints, *ai0, *ai; @@ -810,8 +810,9 @@ static int socksetup(char *listen_addr, int listen_port, int **socklist_p) #else /* NO_IPV6 */ -static int socksetup(char *listen_addr, int listen_port, int **socklist_p) +static int setup_named_sock(char *listen_addr, int listen_port, int **socklist_p, int socknum) { + int *socklist = *socklist_p; struct sockaddr_in sin; int sockfd; long flags; @@ -823,41 +824,53 @@ static int socksetup(char *listen_addr, int listen_port, int **socklist_p) if (listen_addr) { /* Well, host better be an IP address here. */ if (inet_pton(AF_INET, listen_addr, &sin.sin_addr.s_addr) <= 0) - return 0; + return socknum; } else { sin.sin_addr.s_addr = htonl(INADDR_ANY); } sockfd = socket(AF_INET, SOCK_STREAM, 0); if (sockfd < 0) - return 0; + return socknum; if (set_reuse_addr(sockfd)) { close(sockfd); - return 0; + return socknum; } if ( bind(sockfd, (struct sockaddr *)&sin, sizeof sin) < 0 ) { close(sockfd); - return 0; + return socknum; } if (listen(sockfd, 5) < 0) { close(sockfd); - return 0; + return socknum; } flags = fcntl(sockfd, F_GETFD, 0); if (flags >= 0) fcntl(sockfd, F_SETFD, flags | FD_CLOEXEC); - *socklist_p = xmalloc(sizeof(int)); - **socklist_p = sockfd; - return 1; + socklist = xrealloc(socklist, sizeof(int) * (socknum + 1)); + socklist[socknum++] = sockfd; + + *socklist_p = socklist; + return socknum; } #endif +static int socksetup(char *listen_addr, int listen_port, int **socklist_p) +{ + int socknum = 0, *socklist = NULL; + + socknum = setup_named_sock(listen_addr, listen_port, &socklist, socknum); + + *socklist_p = socklist; + return socknum; +} + static int service_loop(int socknum, int *socklist) { struct pollfd *pfd;