From 0f0663c4c8fb55f833befcfa70c9bd9c7a4c52dd Mon Sep 17 00:00:00 2001 From: Johannes Schindelin Date: Wed, 8 Jun 2016 08:32:21 +0200 Subject: [PATCH 1/2] gc/repack: release packs when needed On Windows, files cannot be removed nor renamed if there are still handles held by a process. To remedy that, we introduced the close_all_packs() function. Earlier, we made sure that the packs are released just before `git gc` is spawned, in case that gc wants to remove no-longer needed packs. But this developer forgot that gc itself also needs to let go of packs, e.g. when consolidating all packs via the --aggressive option. Likewise, `git repack -d` wants to delete obsolete packs and therefore needs to close all pack handles, too. Signed-off-by: Johannes Schindelin --- builtin/gc.c | 4 +++- builtin/repack.c | 3 +++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/builtin/gc.c b/builtin/gc.c index e6b84475ae..5e779662f2 100644 --- a/builtin/gc.c +++ b/builtin/gc.c @@ -473,8 +473,10 @@ int cmd_gc(int argc, const char **argv, const char *prefix) report_garbage = report_pack_garbage; reprepare_packed_git(); - if (pack_garbage.nr > 0) + if (pack_garbage.nr > 0) { + close_all_packs(); clean_pack_garbage(); + } if (auto_gc && too_many_loose_objects()) warning(_("There are too many unreachable loose objects; " diff --git a/builtin/repack.c b/builtin/repack.c index f17a68a17d..4aa07aefa9 100644 --- a/builtin/repack.c +++ b/builtin/repack.c @@ -8,6 +8,7 @@ #include "strbuf.h" #include "string-list.h" #include "argv-array.h" +#include "packfile.h" static int delta_base_offset = 1; static int pack_kept_objects = -1; @@ -304,6 +305,8 @@ int cmd_repack(int argc, const char **argv, const char *prefix) if (!names.nr && !quiet) printf("Nothing new to pack.\n"); + close_all_packs(); + /* * Ok we have prepared all new packfiles. * First see if there are packs of the same name and if so From e537979e35eb21cc9399af81ff915430c806107a Mon Sep 17 00:00:00 2001 From: Johannes Schindelin Date: Fri, 25 Aug 2017 12:07:14 +0200 Subject: [PATCH 2/2] Revert "fixup! gc/repack: release packs when needed" The packfile.h file only exists in `pu` so far... This reverts commit b4219bb25ad7d94c352160e5e7ec8b0abf6dcf5a. Signed-off-by: Johannes Schindelin --- builtin/repack.c | 1 - 1 file changed, 1 deletion(-) diff --git a/builtin/repack.c b/builtin/repack.c index 4aa07aefa9..af2e99ce58 100644 --- a/builtin/repack.c +++ b/builtin/repack.c @@ -8,7 +8,6 @@ #include "strbuf.h" #include "string-list.h" #include "argv-array.h" -#include "packfile.h" static int delta_base_offset = 1; static int pack_kept_objects = -1;