From 267807eae10f8f9b2bcf50fdd22b61d68c38e8d5 Mon Sep 17 00:00:00 2001 From: LorenzoPegorari Date: Tue, 3 Mar 2026 02:45:59 +0100 Subject: [PATCH 1/3] doc: gitprotocol-pack: fix pronoun-antecedent agreement Fix "pronoun-antecedent agreement" errors. Signed-off-by: LorenzoPegorari Signed-off-by: Junio C Hamano --- Documentation/gitprotocol-pack.adoc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/gitprotocol-pack.adoc b/Documentation/gitprotocol-pack.adoc index 837b691c89..9952fac188 100644 --- a/Documentation/gitprotocol-pack.adoc +++ b/Documentation/gitprotocol-pack.adoc @@ -65,7 +65,7 @@ Extra Parameters ---------------- The protocol provides a mechanism in which clients can send additional -information in its first message to the server. These are called "Extra +information in their first message to the server. These are called "Extra Parameters", and are supported by the Git, SSH, and HTTP protocols. Each Extra Parameter takes the form of `=` or ``. @@ -277,7 +277,7 @@ out of what the server said it could do with the first 'want' line. filter-request = PKT-LINE("filter" SP filter-spec) ---- -Clients MUST send all the obj-ids it wants from the reference +Clients MUST send all the obj-ids they want from the reference discovery phase as 'want' lines. Clients MUST send at least one 'want' command in the request body. Clients MUST NOT mention an obj-id in a 'want' command which did not appear in the response From b8091b793521cd30bb7972b60f3ca2f53e83bd61 Mon Sep 17 00:00:00 2001 From: LorenzoPegorari Date: Tue, 3 Mar 2026 02:46:10 +0100 Subject: [PATCH 2/3] doc: gitprotocol-pack: improve paragraphs structure Logically separate the introductory sentence from the first transport description to improve readability and structural clarity. Signed-off-by: LorenzoPegorari Signed-off-by: Junio C Hamano --- Documentation/gitprotocol-pack.adoc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/gitprotocol-pack.adoc b/Documentation/gitprotocol-pack.adoc index 9952fac188..f4c9e024b0 100644 --- a/Documentation/gitprotocol-pack.adoc +++ b/Documentation/gitprotocol-pack.adoc @@ -47,7 +47,9 @@ process defined in this protocol is terminated. Transports ---------- There are three transports over which the packfile protocol is -initiated. The Git transport is a simple, unauthenticated server that +initiated. + +The Git transport is a simple, unauthenticated server that takes the command (almost always 'upload-pack', though Git servers can be configured to be globally writable, in which 'receive- pack' initiation is also allowed) with which the client wishes to From a56fa1ca05df589b8aa9c51f71399dd8daf42cf0 Mon Sep 17 00:00:00 2001 From: LorenzoPegorari Date: Tue, 3 Mar 2026 02:46:29 +0100 Subject: [PATCH 3/3] doc: gitprotocol-pack: normalize italic formatting Uniform italic style usage for command and process names. Signed-off-by: LorenzoPegorari Signed-off-by: Junio C Hamano --- Documentation/gitprotocol-pack.adoc | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Documentation/gitprotocol-pack.adoc b/Documentation/gitprotocol-pack.adoc index f4c9e024b0..633deecf2d 100644 --- a/Documentation/gitprotocol-pack.adoc +++ b/Documentation/gitprotocol-pack.adoc @@ -117,7 +117,7 @@ process on the server side over the Git protocol is this: SSH Transport ------------- -Initiating the upload-pack or receive-pack processes over SSH is +Initiating the 'upload-pack' or 'receive-pack' processes over SSH is executing the binary on the server via SSH remote execution. It is basically equivalent to running this: @@ -131,7 +131,7 @@ two commands, or even just one of them. In an ssh:// format URI, it's absolute in the URI, so the '/' after the host name (or port number) is sent as an argument, which is then -read by the remote git-upload-pack exactly as is, so it's effectively +read by the remote 'git-upload-pack' exactly as is, so it's effectively an absolute path in the remote filesystem. git clone ssh://user@example.com/project.git @@ -163,7 +163,7 @@ supports passing environment variables as an argument. A few things to remember here: -- The "command name" is spelled with dash (e.g. git-upload-pack), but +- The "command name" is spelled with dash (e.g. 'git-upload-pack'), but this can be overridden by the client; - The repository path is always quoted with single quotes. @@ -377,10 +377,10 @@ In multi_ack_detailed mode: Without either multi_ack or multi_ack_detailed: - * upload-pack sends "ACK obj-id" on the first common object it finds. + * 'upload-pack' sends "ACK obj-id" on the first common object it finds. After that it says nothing until the client gives it a "done". - * upload-pack sends "NAK" on a flush-pkt if no common object + * 'upload-pack' sends "NAK" on a flush-pkt if no common object has been found yet. If one has been found, and thus an ACK was already sent, it's silent on the flush-pkt.