From 482faa8dafdf5dcf207b866b9c757271d9a45301 Mon Sep 17 00:00:00 2001 From: Junio C Hamano Date: Mon, 17 Jul 2006 13:01:27 -0700 Subject: [PATCH 1/2] git-fetch: fix --keep vs --thin When --keep is specified there is no reason to pass --thin to git-fetch-pack, which are mutually exclusive. This does not hurt because fetch-pack disables thin transfer when both are given internally, but still is confusing. Signed-off-by: Junio C Hamano --- git-fetch.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/git-fetch.sh b/git-fetch.sh index ee99280a2a..b6a223ee46 100755 --- a/git-fetch.sh +++ b/git-fetch.sh @@ -20,6 +20,7 @@ verbose= update_head_ok= exec= upload_pack= +keep=--thin while case "$#" in 0) break ;; esac do case "$1" in @@ -347,7 +348,7 @@ fetch_main () { ( : subshell because we muck with IFS IFS=" $LF" ( - git-fetch-pack $exec $keep --thin "$remote" $rref || echo failed "$remote" + git-fetch-pack $exec $keep "$remote" $rref || echo failed "$remote" ) | while read sha1 remote_name do From e7a0f6714bdfa7e3a169cc756a05cbbf787997eb Mon Sep 17 00:00:00 2001 From: Junio C Hamano Date: Mon, 17 Jul 2006 13:08:14 -0700 Subject: [PATCH 2/2] unpack-objects: remove stale and confusing comment The very initial version of unpack-objects.c::unpack_all() used to unpack from the end of the pack, but since end of June last year it was changed to stream from the front and the comment does not reflect the reality anymore. Signed-off-by: Junio C Hamano --- unpack-objects.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/unpack-objects.c b/unpack-objects.c index 3b824b04a2..48c1ee7968 100644 --- a/unpack-objects.c +++ b/unpack-objects.c @@ -241,11 +241,6 @@ static void unpack_one(unsigned nr, unsigned total) } } -/* - * We unpack from the end, older files first. Now, usually - * there are deltas etc, so we'll not actually write the - * objects in that order, but we might as well try.. - */ static void unpack_all(void) { int i;