global/git
1
0
Fork 0
mirror of https://github.com/git/git.git synced 2026-01-10 10:13:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

refs: refactor reference status flags

Browse Source 
The reference flags encode information like whether or not a reference
is a symbolic reference or whether it may be broken. This information is
stored in a `int flags` bitfield, which is in conflict with our modern
best practices; we tend to use an unsigned integer to store flags.

Change the type of the field to be `unsigned`. While at it, refactor the
individual flags to be part of an `enum` instead of using preprocessor
defines.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Patrick Steinhardt
2025-10-23 09:16:13 +02:00
committed by Junio C Hamano
parent 4cea042287
commit eb2934d94b
1 changed files with 21 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
refs.h
View File

@@ -333,27 +333,28 @@ struct ref_transaction;
* stored in ref_iterator::flags. Other bits are for internal use * stored in ref_iterator::flags. Other bits are for internal use
* only: * only:
*/ */
enum reference_status {
/* Reference is a symbolic reference. */
REF_ISSYMREF = (1 << 0),
/* Reference is a symbolic reference. */ /* Reference is a packed reference. */
#define REF_ISSYMREF 0x01 REF_ISPACKED = (1 << 1),
/* Reference is a packed reference. */ /*
#define REF_ISPACKED 0x02 * Reference cannot be resolved to an object name: dangling symbolic
* reference (directly or indirectly), corrupt reference file,
* reference exists but name is bad, or symbolic reference refers to
* ill-formatted reference name.
*/
REF_ISBROKEN = (1 << 2),
/* /*
* Reference cannot be resolved to an object name: dangling symbolic * Reference name is not well formed.
* reference (directly or indirectly), corrupt reference file, *
* reference exists but name is bad, or symbolic reference refers to * See git-check-ref-format(1) for the definition of well formed ref names.
* ill-formatted reference name. */
*/ REF_BAD_NAME = (1 << 3),
#define REF_ISBROKEN 0x04 };
/*
* Reference name is not well formed.
*
* See git-check-ref-format(1) for the definition of well formed ref names.
*/
#define REF_BAD_NAME 0x08
/* A reference passed to `for_each_ref()`-style callbacks. */ /* A reference passed to `for_each_ref()`-style callbacks. */
struct reference { struct reference {
@@ -370,8 +371,8 @@ struct reference {
*/ */
const struct object_id *oid; const struct object_id *oid;
/* A bitfield of `REF_` flags. */ /* A bitfield of `enum reference_status` flags. */
int flags; unsigned flags;
}; };
/* /*