Patrick Steinhardt e3d4d7787c add-patch: split out struct interactive_options ...

The `struct add_p_opt` is reused both by our infra for "git add -p" and
"git add -i". Users of `run_add_i()` for example are expected to pass
`struct add_p_opt`. This is somewhat confusing and raises the question
of which options apply to what part of the stack.

But things are even more confusing than that: while callers are expected
to pass in `struct add_p_opt`, these options ultimately get used to
initialize a `struct add_i_state` that is used by both subsystems. So we
are basically going full circle here.

Refactor the code and split out a new `struct interactive_options` that
hosts common options used by both. These options are then applied to a
`struct interactive_config` that hosts common configuration.

This refactoring doesn't yet fully detangle the two subsystems from one
another, as we still end up calling `init_add_i_state()` in the "git add
-p" subsystem. This will be fixed in a subsequent commit.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

2026-03-03 15:09:35 -08:00

..

add.c

add-patch: split out struct interactive_options

2026-03-03 15:09:35 -08:00

am.c

Merge branch 'ps/commit-list-functions-renamed'

2026-02-13 13:39:25 -08:00

annotate.c

Merge branch 'jc/a-commands-without-the-repo'

2024-10-25 14:02:36 -04:00

apply.c

builtin: use default hash when outside a repository

2025-07-01 14:58:24 -07:00

archive.c

archive: remove the_repository global variable

2024-10-11 09:37:18 -07:00

backfill.c

builtin/backfill: fix flags passed to odb_has_object()

2026-02-12 11:05:08 -08:00

bisect.c

Merge branch 'ps/ref-peeled-tags'

2025-11-19 10:55:39 -08:00

blame.c

Merge branch 'rs/clean-includes'

2026-02-17 13:30:42 -08:00

branch.c

branch: advice using git-help(1) instead of man(1)

2025-12-03 00:16:05 -08:00

bugreport.c

object-file: move safe_create_leading_directories() into "path.c"

2025-04-15 08:24:35 -07:00

bundle.c

Merge branch 'jt/bundle-fsck'

2024-12-13 07:33:36 -08:00

cat-file.c

Merge branch 'ps/odb-for-each-object'

2026-03-02 17:06:50 -08:00

check-attr.c

config: drop git_config() wrapper

2025-07-23 08:15:18 -07:00

check-ignore.c

config: move Git config parsing into "environment.c"

2025-07-23 08:15:22 -07:00

check-mailmap.c

config: move Git config parsing into "environment.c"

2025-07-23 08:15:22 -07:00

check-ref-format.c

builtin: send usage() help text to standard output

2025-01-17 13:30:03 -08:00

checkout--worker.c

config: move Git config parsing into "environment.c"

2025-07-23 08:15:22 -07:00

checkout-index.c

config: move Git config parsing into "environment.c"

2025-07-23 08:15:22 -07:00

checkout.c

add-patch: split out struct interactive_options

2026-03-03 15:09:35 -08:00

clean.c

Merge branch 'jk/color-variable-fixes'

2025-09-29 11:40:35 -07:00

clone.c

fetch-pack: wire up and enable auto filter logic

2026-02-17 11:46:41 -08:00

column.c

config: drop git_config() wrapper

2025-07-23 08:15:18 -07:00

commit-graph.c

commit-graph: add new config for changed-paths & recommend it in scalar

2025-10-22 10:40:11 -07:00

commit-tree.c

commit: rename free_commit_list() to conform to coding guidelines

2026-01-15 05:32:31 -08:00

commit.c

add-patch: split out struct interactive_options

2026-03-03 15:09:35 -08:00

config.c

Merge branch 'rs/config-set-multi-error-message-fix'

2025-12-05 14:49:59 +09:00

count-objects.c

packfile: introduce macro to iterate through packs

2025-10-16 14:42:39 -07:00

credential-cache--daemon.c

config: drop git_config_get_bool() wrapper

2025-07-23 08:15:20 -07:00

credential-cache.c

Merge branch 'rj/cygwin-exit'

2024-11-01 12:53:19 -04:00

credential-store.c

builtin/credential-store: move is_rfc3986_unreserved to url.[ch]

2026-01-12 11:56:56 -08:00

credential.c

config: move Git config parsing into "environment.c"

2025-07-23 08:15:22 -07:00

describe.c

commit: rename free_commit_list() to conform to coding guidelines

2026-01-15 05:32:31 -08:00

diagnose.c

object-file: move safe_create_leading_directories() into "path.c"

2025-04-15 08:24:35 -07:00

diff-files.c

config: drop git_config() wrapper

2025-07-23 08:15:18 -07:00

diff-index.c

config: drop git_config() wrapper

2025-07-23 08:15:18 -07:00

diff-pairs.c

builtin/diff-pairs: allow explicit diff queue flush

2025-03-03 08:17:47 -08:00

diff-tree.c

Merge branch 'ps/commit-list-functions-renamed'

2026-02-13 13:39:25 -08:00

diff.c

diff: --no-index should ignore the worktree

2025-08-09 17:22:01 -07:00

difftool.c

odb: rename repo_read_object_file()

2025-07-01 14:46:38 -07:00

fast-export.c

string-list: add string_list_sort_u() that mimics "sort -u"

2026-01-29 09:32:50 -08:00

fast-import.c

packfile: move packfile store into object source

2026-01-09 06:40:07 -08:00

fetch-pack.c

builtin/fetch-pack: cleanup before return error

2025-06-04 08:52:25 -07:00

fetch.c

fetch-pack: wire up and enable auto filter logic

2026-02-17 11:46:41 -08:00

fmt-merge-msg.c

builtin/fmt-merge-msg: stop depending on 'the_repository'

2025-08-11 09:19:40 -07:00

for-each-ref.c

Merge branch 'ms/refs-list'

2025-08-22 13:13:20 -07:00

for-each-repo.c

global: trivial conversions to fix -Wsign-compare warnings

2024-12-06 20:20:04 +09:00

fsck.c

Merge branch 'ps/object-info-bits-cleanup'

2026-03-02 17:06:52 -08:00

fsmonitor--daemon.c

config: move Git config parsing into "environment.c"

2025-07-23 08:15:22 -07:00

gc.c

Merge branch 'ps/commit-list-functions-renamed'

2026-02-13 13:39:25 -08:00

get-tar-commit-id.c

builtin: send usage() help text to standard output

2025-01-17 13:30:03 -08:00

grep.c

packfile: only prepare owning store in packfile_store_prepare()

2026-01-09 06:40:07 -08:00

hash-object.c

config: move Git config parsing into "environment.c"

2025-07-23 08:15:22 -07:00

help.c

completion: fix zsh alias listing for subsection aliases

2026-02-19 10:13:20 -08:00

history.c

builtin/history: rename "--ref-action=" to "--update-refs="

2026-02-17 08:37:51 -08:00

hook.c

Revert "Merge branch 'ar/run-command-hook'"

2026-01-15 13:02:38 -08:00

index-pack.c

packfile: move packfile store into object source

2026-01-09 06:40:07 -08:00

init-db.c

Merge branch 'ps/parse-options-integers'

2025-04-24 17:25:34 -07:00

interpret-trailers.c

config: move Git config parsing into "environment.c"

2025-07-23 08:15:22 -07:00

last-modified.c

Merge branch 'tc/last-modified-not-a-tree'

2026-02-13 13:39:25 -08:00

log.c

Merge branch 'mf/format-patch-honor-from-for-cover-letter'

2026-02-27 15:11:54 -08:00

ls-files.c

Merge branch 'ds/ls-files-lazy-unsparse'

2025-09-08 14:54:35 -07:00

ls-remote.c

ref-filter: propagate peeled object ID

2025-11-04 07:32:25 -08:00

ls-tree.c

cocci: convert parse_tree functions to repo_ variants

2026-01-09 18:36:18 -08:00

mailinfo.c

mailinfo: stop using the_repository

2024-12-18 10:44:31 -08:00

mailsplit.c

builtin: send usage() help text to standard output

2025-01-17 13:30:03 -08:00

merge-base.c

commit: rename free_commit_list() to conform to coding guidelines

2026-01-15 05:32:31 -08:00

merge-file.c

Merge branch 'rs/xdiff-wo-the-repository'

2026-02-17 13:30:42 -08:00

merge-index.c

builtin: send usage() help text to standard output

2025-01-17 13:30:03 -08:00

merge-ours.c

merge-ours: integrate with sparse-index

2026-02-06 11:45:33 -08:00

merge-recursive.c

builtin: also setup gently for --help-all

2025-08-08 11:13:12 -07:00

merge-tree.c

Merge branch 'ps/commit-list-functions-renamed'

2026-02-13 13:39:25 -08:00

merge.c

Merge branch 'ps/commit-list-functions-renamed'

2026-02-13 13:39:25 -08:00

mktag.c

Merge branch 'ps/object-file-wo-the-repository'

2025-08-05 11:53:55 -07:00

mktree.c

odb: introduce odb_write_object()

2025-07-16 22:16:15 -07:00

multi-pack-index.c

Merge branch 'ps/object-store-midx-dedup-info'

2025-09-12 10:41:18 -07:00

mv.c

config: drop git_config() wrapper

2025-07-23 08:15:18 -07:00

name-rev.c

name-rev: use commit_stack

2025-12-25 08:29:27 +09:00

notes.c

Merge branch 'jc/strbuf-split'

2025-08-21 13:47:00 -07:00

pack-objects.c

Merge branch 'ps/odb-for-each-object'

2026-03-02 17:06:50 -08:00

pack-redundant.c

pack-redundant: fix memory leak when open_pack_index() fails

2026-02-21 21:26:53 -08:00

pack-refs.c

builtin/pack-refs: factor out core logic into a shared library

2025-09-19 10:02:55 -07:00

patch-id.c

patch-id: use “patch ID” throughout

2026-01-09 06:07:21 -08:00

prune-packed.c

builtin: remove USE_THE_REPOSITORY for those without the_repository

2024-09-13 14:33:30 -07:00

prune.c

Merge branch 'ps/object-file-wo-the-repository'

2025-08-05 11:53:55 -07:00

pull.c

commit: rename free_commit_list() to conform to coding guidelines

2026-01-15 05:32:31 -08:00

push.c

color: use git_colorbool enum type to store colorbools

2025-09-16 17:59:53 -07:00

range-diff.c

Merge branch 'kh/format-patch-range-diff-notes'

2025-10-14 12:56:09 -07:00

read-tree.c

cocci: convert parse_tree functions to repo_ variants

2026-01-09 18:36:18 -08:00

rebase.c

commit: rename free_commit_list() to conform to coding guidelines

2026-01-15 05:32:31 -08:00

receive-pack.c

Merge branch 'cf/c23-const-preserving-strchr-updates-0'

2026-02-13 13:39:25 -08:00

reflog.c

Merge branch 'ps/reflog-migrate-fixes' into maint-2.51

2025-10-15 10:29:28 -07:00

refs.c

Merge branch 'ms/refs-optimize'

2025-10-02 12:26:12 -07:00

remote-ext.c

builtin: send usage() help text to standard output

2025-01-17 13:30:03 -08:00

remote-fd.c

builtin: send usage() help text to standard output

2025-01-17 13:30:03 -08:00

remote.c

global: constify some pointers that are not written to

2026-02-05 17:52:49 -08:00

repack.c

builtin/repack: handle promisor packs with geometric repacking

2026-01-14 06:29:24 -08:00

replace.c

refs: introduce wrapper struct for each_ref_fn

2025-11-04 07:32:24 -08:00

replay.c

builtin/replay: move core logic into "libgit.a"

2026-01-13 05:41:16 -08:00

repo.c

repo: add new flag --keys to git-repo-info

2026-02-14 10:12:10 -08:00

rerere.c

config: drop git_config() wrapper

2025-07-23 08:15:18 -07:00

reset.c

add-patch: split out struct interactive_options

2026-03-03 15:09:35 -08:00

rev-list.c

commit: rename free_commit_list() to conform to coding guidelines

2026-01-15 05:32:31 -08:00

rev-parse.c

Merge branch 'ps/ref-peeled-tags'

2025-11-19 10:55:39 -08:00

revert.c

Merge branch 'pw/3.0-commentchar-auto-deprecation'

2025-09-18 10:07:00 -07:00

rm.c

config: move Git config parsing into "environment.c"

2025-07-23 08:15:22 -07:00

send-pack.c

config: move Git config parsing into "environment.c"

2025-07-23 08:15:22 -07:00

shortlog.c

global: constify some pointers that are not written to

2026-02-05 17:52:49 -08:00

show-branch.c

commit: rename free_commit_list() to conform to coding guidelines

2026-01-15 05:32:31 -08:00

show-index.c

show-index: use gettext wrapping in user facing error messages

2026-01-30 08:58:12 -08:00

show-ref.c

builtin/show-ref: convert to use reference_get_peeled_oid()

2025-11-04 07:32:25 -08:00

sparse-checkout.c

sparse-checkout: use string_list_sort_u

2026-02-12 20:09:24 -08:00

stash.c

add-patch: split out struct interactive_options

2026-03-03 15:09:35 -08:00

stripspace.c

config: drop git_config() wrapper

2025-07-23 08:15:18 -07:00

submodule--helper.c

Merge branch 'ar/submodule-gitdir-tweak'

2026-02-05 15:41:58 -08:00

symbolic-ref.c

config: move Git config parsing into "environment.c"

2025-07-23 08:15:22 -07:00

tag.c

tag: support arbitrary repositories in gpg_verify_tag()

2025-12-29 22:02:53 +09:00

unpack-file.c

config: move Git config parsing into "environment.c"

2025-07-23 08:15:22 -07:00

unpack-objects.c

object-file: refactor writing objects via a stream

2025-11-03 12:18:48 -08:00

update-index.c

odb: add transaction interface

2025-09-16 11:37:06 -07:00

update-ref.c

update-ref: utilize rejected error details if available

2026-01-25 22:27:33 -08:00

update-server-info.c

config: move Git config parsing into "environment.c"

2025-07-23 08:15:22 -07:00

upload-archive.c

path: move enter_repo() into "setup.c"

2025-11-19 17:41:03 -08:00

upload-pack.c

path: move enter_repo() into "setup.c"

2025-11-19 17:41:03 -08:00

var.c

Merge branch 'jc/string-list-split'

2025-08-21 13:46:59 -07:00

verify-commit.c

config: move Git config parsing into "environment.c"

2025-07-23 08:15:22 -07:00

verify-pack.c

config: move Git config parsing into "environment.c"

2025-07-23 08:15:22 -07:00

verify-tag.c

tag: support arbitrary repositories in gpg_verify_tag()

2025-12-29 22:02:53 +09:00

worktree.c

Merge branch 'sb/doc-worktree-prune-expire-improvement'

2026-02-09 12:09:10 -08:00

write-tree.c

config: move Git config parsing into "environment.c"

2025-07-23 08:15:22 -07:00