Ævar Arnfjörð Bjarmason 486620ae0c name-rev: don't xstrdup() an already dup'd string ...

When "add_to_tip_table()" is called with a non-zero
"shorten_unambiguous" we always return an xstrdup()'d string, which
we'd then xstrdup() again, leaking memory. See [1] and [2] for how
this leak came about.

We could xstrdup() only if "shorten_unambiguous" wasn't true, but
let's instead inline this code, so that information on whether we need
to xstrdup() is contained within add_to_tip_table().

1. 98c5c4ad01 (name-rev: allow to specify a subpath for --refs
   option, 2013-06-18)
2. b23e0b9353 (name-rev: allow converting the exact object name at
   the tip of a ref, 2013-07-07)

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

2023-02-06 15:34:37 -08:00

..

add.c

Merge branch 'jk/unused-post-2.39'

2022-12-26 11:42:05 +09:00

am.c

Merge branch 'rs/dup-array'

2023-01-21 17:21:58 -08:00

annotate.c

…

apply.c

…

archive.c

parse-options: PARSE_OPT_KEEP_UNKNOWN only applies to --options

2022-08-19 11:13:14 -07:00

bisect.c

bisect: remove Cogito-related code

2023-01-13 14:17:14 -08:00

blame.c

doc txt & -h consistency: make "annotate" consistent

2022-10-13 09:32:57 -07:00

branch.c

Merge branch 'rj/branch-copy-and-rename'

2022-12-19 11:46:18 +09:00

bugreport.c

built-ins: use free() not UNLEAK() if trivial, rm dead code

2022-11-21 12:32:48 +09:00

bundle.c

Merge branch 'ab/bundle-wo-args'

2023-01-05 15:07:22 +09:00

cat-file.c

Merge branch 'sa/cat-file-mailmap--batch-check'

2023-01-05 15:07:17 +09:00

check-attr.c

attr: add flag --source to work with tree-ish

2023-01-14 08:49:55 -08:00

check-ignore.c

cocci: apply "pending" index-compatibility to some "builtin/*.c"

2022-11-21 12:06:15 +09:00

check-mailmap.c

…

check-ref-format.c

check-ref-format: fix trivial memory leak

2022-07-01 11:43:42 -07:00

checkout--worker.c

…

checkout-index.c

cocci: apply "pending" index-compatibility to some "builtin/*.c"

2022-11-21 12:06:15 +09:00

checkout.c

*: fix typos which duplicate a word

2023-01-08 10:28:34 +09:00

clean.c

various: add missing clear_pathspec(), fix leaks

2023-02-06 15:34:37 -08:00

clone.c

clone: use free() instead of UNLEAK()

2023-02-06 15:34:37 -08:00

column.c

…

commit-graph.c

commit-graph: use free_commit_graph() instead of UNLEAK()

2023-02-06 15:34:36 -08:00

commit-tree.c

doc txt & -h consistency: add missing options

2022-10-13 09:32:57 -07:00

commit.c

Merge branch 'ab/various-leak-fixes'

2022-12-14 15:55:46 +09:00

config.c

built-ins: use free() not UNLEAK() if trivial, rm dead code

2022-11-21 12:32:48 +09:00

count-objects.c

…

credential-cache--daemon.c

doc txt & -h consistency: use "git foo" form, not "git-foo"

2022-10-13 09:32:57 -07:00

credential-cache.c

…

credential-store.c

…

credential.c

…

describe.c

cocci: apply "pending" index-compatibility to some "builtin/*.c"

2022-11-21 12:06:15 +09:00

diagnose.c

Merge branch 'ab/doc-synopsis-and-cmd-usage'

2022-10-28 11:26:54 -07:00

diff-files.c

cocci: apply "pending" index-compatibility to some "builtin/*.c"

2022-11-21 12:06:15 +09:00

diff-index.c

cocci: apply "pending" index-compatibility to some "builtin/*.c"

2022-11-21 12:06:15 +09:00

diff-tree.c

cocci: apply "pending" index-compatibility to some "builtin/*.c"

2022-11-21 12:06:15 +09:00

diff.c

Merge branch 'ab/various-leak-fixes'

2022-12-14 15:55:46 +09:00

difftool.c

treewide: always have a valid "index_state.repo" member

2023-01-17 14:32:06 -08:00

fast-export.c

diff: mark unused parameters in callbacks

2022-12-13 22:16:23 +09:00

fast-import.c

git-compat-util.h: use "UNUSED", not "UNUSED(var)"

2022-09-01 10:49:48 -07:00

fetch-pack.c

list-objects-filter: add and use initializers

2022-09-12 08:38:59 -07:00

fetch.c

fetch: fix duplicate remote parallel fetch bug

2023-01-19 14:41:48 -08:00

fmt-merge-msg.c

…

for-each-ref.c

…

for-each-repo.c

for-each-repo: interpolate repo path arguments

2022-11-14 22:39:25 -05:00

fsck.c

cocci: apply "pending" index-compatibility to some "builtin/*.c"

2022-11-21 12:06:15 +09:00

fsmonitor--daemon.c

Merge branch 'sx/pthread-error-check-fix'

2022-12-19 11:46:17 +09:00

gc.c

Merge branch 'rp/maintenance-qol'

2022-11-23 11:22:24 +09:00

get-tar-commit-id.c

…

grep.c

builtin/{grep,log}.: don't define "USE_THE_INDEX_COMPATIBILITY_MACROS"

2022-11-21 12:06:14 +09:00

hash-object.c

Merge branch 'jk/hash-object-literally-fd-leak'

2023-01-27 08:51:41 -08:00

help.c

Merge branch 'ab/doc-synopsis-and-cmd-usage'

2022-10-28 11:26:54 -07:00

hook.c

builtin/hook.c: let parse-options parse subcommands

2022-08-19 11:13:15 -07:00

index-pack.c

i18n: fix mismatched camelCase config variables

2022-06-17 10:38:26 -07:00

init-db.c

doc txt & -h consistency: add missing options

2022-10-13 09:32:57 -07:00

interpret-trailers.c

doc txt & -h consistency: add missing options

2022-10-13 09:32:57 -07:00

log.c

Merge branch 'jc/format-patch-v-unleak'

2023-01-23 13:39:52 -08:00

ls-files.c

ls-files: fix a --with-tree memory leak

2022-11-21 12:32:48 +09:00

ls-remote.c

doc txt & -h consistency: add missing options and labels

2022-10-13 09:32:56 -07:00

ls-tree.c

Merge branch 'rs/ls-tree-path-expansion-fix'

2023-01-23 13:39:50 -08:00

mailinfo.c

…

mailsplit.c

Merge branch 'ep/maint-equals-null-cocci'

2022-05-20 15:26:59 -07:00

merge-base.c

doc txt & -h consistency: make output order consistent

2022-10-13 09:32:56 -07:00

merge-file.c

merge-file: fix memory leaks on error path

2022-07-01 11:43:43 -07:00

merge-index.c

cocci: apply "pending" index-compatibility to some "builtin/*.c"

2022-11-21 12:06:15 +09:00

merge-ours.c

cocci: apply "pending" index-compatibility to some "builtin/*.c"

2022-11-21 12:06:15 +09:00

merge-recursive.c

…

merge-tree.c

Merge branch 'jk/unused-post-2.39'

2022-12-26 11:42:05 +09:00

merge.c

merge: break out of all_strategy loop when strategy is found

2023-01-13 10:24:57 -08:00

mktag.c

…

mktree.c

mktree: do not check type of remote objects

2022-06-21 10:12:15 -07:00

multi-pack-index.c

multi-pack-index: avoid writing to global in option callback

2022-10-06 09:56:51 -07:00

mv.c

cocci: apply "pending" index-compatibility to some "builtin/*.c"

2022-11-21 12:06:15 +09:00

name-rev.c

name-rev: don't xstrdup() an already dup'd string

2023-02-06 15:34:37 -08:00

notes.c

notes: avoid empty line in template

2022-11-16 14:57:32 -05:00

pack-objects.c

attr: add flag --source to work with tree-ish

2023-01-14 08:49:55 -08:00

pack-redundant.c

doc txt & -h consistency: fix mismatching labels

2022-10-13 09:32:56 -07:00

pack-refs.c

doc txt & -h consistency: add missing options and labels

2022-10-13 09:32:56 -07:00

patch-id.c

builtin: patch-id: remove unused diff-tree prefix

2022-10-24 15:44:20 -07:00

prune-packed.c

…

prune.c

prune: quiet ENOENT on missing directories

2022-11-21 15:58:54 +09:00

pull.c

{builtin/*,repository}.c: add & use "USE_THE_INDEX_VARIABLE"

2022-11-21 12:06:15 +09:00

push.c

Doc: document push.recurseSubmodules=only

2022-11-14 16:55:50 -05:00

range-diff.c

diff: factor out add_diff_options()

2022-12-02 08:25:29 +09:00

read-tree.c

read-tree: add "--super-prefix" option, eliminate global

2022-12-26 10:21:44 +09:00

rebase.c

rebase: cleanup "--exec" option handling

2023-01-13 12:23:14 -08:00

receive-pack.c

receive-pack: only use visible refs for connectivity check

2022-11-17 16:22:52 -05:00

reflog.c

refs: unify parse_worktree_ref() and ref_type()

2022-09-19 11:11:11 -07:00

remote-ext.c

convert trivial uses of strncmp() to skip_prefix()

2023-01-08 10:34:37 +09:00

remote-fd.c

convert trivial uses of strncmp() to starts_with()

2023-01-08 10:34:35 +09:00

remote.c

Merge branch 'rs/no-more-run-command-v'

2022-11-08 17:15:12 -05:00

repack.c

Merge branch 'ab/various-leak-fixes'

2022-12-14 15:55:46 +09:00

replace.c

refs: use ref_namespaces for replace refs base

2022-08-05 14:13:12 -07:00

rerere.c

diff: mark unused parameters in callbacks

2022-12-13 22:16:23 +09:00

reset.c

various: add missing clear_pathspec(), fix leaks

2023-02-06 15:34:37 -08:00

rev-list.c

Merge branch 'ps/receive-use-only-advertised'

2022-11-23 11:22:25 +09:00

rev-parse.c

Merge branch 'ab/various-leak-fixes'

2022-12-14 15:55:46 +09:00

revert.c

Merge branch 'ab/various-leak-fixes'

2022-12-14 15:55:46 +09:00

rm.c

submodule.c & submodule--helper: pass along "super_prefix" param

2022-12-26 10:21:43 +09:00

send-pack.c

doc txt & -h consistency: add missing options and labels

2022-10-13 09:32:56 -07:00

shortlog.c

shortlog: implement --group=committer in terms of --group=<format>

2022-10-24 14:48:05 -07:00

show-branch.c

Merge branch 'ab/doc-synopsis-and-cmd-usage'

2022-10-28 11:26:54 -07:00

show-index.c

…

show-ref.c

Merge branch 'ab/doc-synopsis-and-cmd-usage'

2022-10-28 11:26:54 -07:00

sparse-checkout.c

treewide: always have a valid "index_state.repo" member

2023-01-17 14:32:06 -08:00

stash.c

various: add missing clear_pathspec(), fix leaks

2023-02-06 15:34:37 -08:00

stripspace.c

…

submodule--helper.c

*: fix typos which duplicate a word

2023-01-08 10:28:34 +09:00

symbolic-ref.c

Merge branch 'ab/doc-synopsis-and-cmd-usage'

2022-10-28 11:26:54 -07:00

tag.c

doc txt & -h consistency: add missing options and labels

2022-10-13 09:32:56 -07:00

unpack-file.c

unpack-file: fix ancient leak in create_temp_file()

2022-11-21 12:32:48 +09:00

unpack-objects.c

unpack-objects: use stream_loose_object() to unpack large objects

2022-06-13 10:22:36 -07:00

update-index.c

cocci: apply "pending" index-compatibility to some "builtin/*.c"

2022-11-21 12:06:15 +09:00

update-ref.c

…

update-server-info.c

doc txt & -h consistency: add missing options and labels

2022-10-13 09:32:56 -07:00

upload-archive.c

doc txt & -h consistency: fix mismatching labels

2022-10-13 09:32:56 -07:00

upload-pack.c

doc txt & -h consistency: add missing options and labels

2022-10-13 09:32:56 -07:00

var.c

var: add GIT_SEQUENCE_EDITOR variable

2022-12-18 11:48:26 +09:00

verify-commit.c

doc txt & -h consistency: add missing options and labels

2022-10-13 09:32:56 -07:00

verify-pack.c

doc txt & -h consistency: add or fix optional "--" syntax

2022-10-13 09:32:56 -07:00

verify-tag.c

doc txt & -h consistency: add missing options and labels

2022-10-13 09:32:56 -07:00

worktree.c

treewide: always have a valid "index_state.repo" member

2023-01-17 14:32:06 -08:00

write-tree.c

…