Files
git/builtin
Kristoffer Haugsbakk 71fd6c695c range-diff: rename other_arg to log_arg
Rename `other_arg` to `log_arg` in `range_diff_options` and
related places.

“Other argument” comes from bd361918 (range-diff: pass through --notes
to `git log`, 2019-11-20) which introduced Git notes handling to
git-range-diff(1) by passing that option on to git-log(1). And that kind
of name might be fine in a local context. However, it was initially
spread among multiple files, and is now[1] part of the
`range_diff_options` struct. It is, prima facie, difficult to guess what
“other” means, especially when just looking at the struct.

But with a little reading we find out that it is used for `--[no-]notes`
and `--diff-merges`, which are both passed on to git-log(1). We should
just rename it to reflect this role; `log_arg` suggests, along with the
`strvec` type, that it is used to pass extra arguments to git-log(1).

† 1: since f1ce6c19 (range-diff: combine all options in a single data
     structure, 2021-02-05)

Suggested-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Kristoffer Haugsbakk <code@khaugsbakk.name>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2025-09-25 11:34:11 -07:00
..
2025-07-01 14:46:38 -07:00
2025-08-21 13:46:59 -07:00
2024-12-13 07:33:36 -08:00
2025-07-23 08:15:18 -07:00
2025-08-21 13:47:00 -07:00
2025-07-23 08:15:18 -07:00
2025-07-23 08:15:18 -07:00
2025-07-23 08:15:18 -07:00
2025-07-23 08:15:18 -07:00
2025-07-01 14:46:38 -07:00
2025-08-22 13:13:20 -07:00
2025-08-21 13:46:58 -07:00
2025-08-21 13:46:58 -07:00
2025-09-25 11:34:11 -07:00
2024-12-18 10:44:31 -08:00
2025-08-21 13:47:00 -07:00
2025-07-16 22:16:15 -07:00
2025-07-23 08:15:18 -07:00
2025-07-23 08:15:18 -07:00
2025-08-21 13:47:00 -07:00
2025-07-23 08:15:18 -07:00
2025-09-02 09:58:35 -07:00
2025-08-21 13:46:58 -07:00
2025-09-04 11:36:40 -07:00
2025-07-23 08:15:18 -07:00
2025-08-04 08:10:33 -07:00
2025-07-23 08:15:18 -07:00
2025-07-23 08:15:18 -07:00
2025-08-21 13:46:58 -07:00
2025-07-23 08:15:18 -07:00
2024-12-18 10:44:30 -08:00
2025-08-21 13:46:59 -07:00