global/git
1
0
Fork 0
mirror of https://github.com/git/git.git synced 2026-03-13 10:23:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

compat/pread.c: Add foward decl to fix warning

Browse Source 
read_in_full()'s is used in compat/pread.c.  read_in_full() is
declared in cache.h. But we can't include cache.h because too
many macros are defined there.  Using read_in_full() without
including cache.h is dangerous because we wouldn't recognize if
its prototyp changed.  gcc issues a warning about that.

This commit adds a forward decl to git-compat-util.h.
git-compat-util.h is included by compat/pread.c _and_ cache.h.
Hence, changes in cache.h would be detected.

Signed-off-by: Steffen Prohaska <prohaska@zib.de>
This commit is contained in:
Steffen Prohaska
2007-11-17 20:48:14 +01:00
parent d3dcd10775
commit 31023be999
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
compat/pread.c
View File

@@ -1,7 +1,5 @@
#include "../git-compat-util.h"
int read_in_full(int fd, void *buf, size_t count);
ssize_t git_pread(int fd, void *buf, size_t count, off_t offset)
{
off_t current_offset;

4
git-compat-util.h
View File

@@ -153,6 +153,10 @@ extern int git_munmap(void *start, size_t length);
#define pread git_pread
extern ssize_t git_pread(int fd, void *buf, size_t count, off_t offset);
#endif
/* Forward decl that will remind us if its twin in cache.h changes.
This function in used in compat/pread.c. But we can't include
cache.h there. */
extern int read_in_full(int fd, void *buf, size_t count);
#ifdef NO_SETENV
#define setenv gitsetenv