global/git
1
0
Fork 0
mirror of https://github.com/git/git.git synced 2026-03-19 21:20:05 +01:00
Code Issues Packages Projects Releases Wiki Activity

mingw: do not crash on open(NULL, ...)

Browse Source 
fetch_and_setup_pack_index() apparently pass a NULL-pointer to
parse_pack_index(), which in turn pass it to check_packed_git_idx(),
which again pass it to open(). Since open() already sets errno
correctly for the NULL-case, let's just avoid the problematic strcmp.

Acked-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>
This commit is contained in:
Erik Faye-Lund
2010-09-23 17:35:25 +00:00
committed by Pat Thoyts
parent f25a75f0db
commit 351dbaeff9
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
compat/mingw.c
View File

@@ -297,7 +297,7 @@ int mingw_open (const char *filename, int oflags, ...)
mode = va_arg(args, int);
va_end(args);
if (!strcmp(filename, "/dev/null"))
if (filename && !strcmp(filename, "/dev/null"))
filename = "nul";
fd = open(filename, oflags, mode);