global/git
1
0
Fork 0
mirror of https://github.com/git/git.git synced 2026-03-10 17:18:43 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'ty/patch-ids-document-lazy-eval' into jch

Browse Source 
* ty/patch-ids-document-lazy-eval:
  patch-ids: document intentional const-casting in patch_id_neq()
This commit is contained in:
Junio C Hamano
2026-03-09 14:41:22 -07:00
parent 738d3d0f13 4c223571be
commit 6750ab456d
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
patch-ids.c
View File

@@ -41,7 +41,14 @@ static int patch_id_neq(const void *cmpfn_data,
const struct hashmap_entry *entry_or_key,
const void *keydata UNUSED)
{
/* NEEDSWORK: const correctness? */
/*
* We drop the 'const' modifier here intentionally.
*
* Even though eptr and entry_or_key are const, we want to
* lazily compute their .patch_id members; see b3dfeebb (rebase:
* avoid computing unnecessary patch IDs, 2016-07-29). So we cast
* the constness away with container_of().
*/
struct diff_options *opt = (void *)cmpfn_data;
struct patch_id *a, *b;