global/git
1
0
Fork 0
mirror of https://github.com/git/git.git synced 2026-01-11 10:38:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

builtin/repack.c: provide pack locations to generated_pack_install()

Browse Source 
Repeat what was done in the preceding commit for the
`generated_pack_install()` function, which needs both "packdir" and
"packtmp".

(As an aside, it is somewhat unfortunate that the final three parameters
to this function are all "const char *", making errors like passing
"packdir" and "packtmp" in the wrong order easy. We could define a new
structure here, but that may be too heavy-handed.)

Signed-off-by: Taylor Blau <me@ttaylorr.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Taylor Blau
2025-10-15 18:28:26 -04:00
committed by Junio C Hamano
parent 184f0abeb8
commit 7036d131ae
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
builtin/repack.c
View File

@@ -185,7 +185,8 @@ static int generated_pack_has_ext(const struct generated_pack *pack,
}
static void generated_pack_install(struct generated_pack *pack,
const char *name)
const char *name,
const char *packdir, const char *packtmp)
{
int ext;
for (ext = 0; ext < ARRAY_SIZE(exts); ext++) {
@@ -1468,7 +1469,8 @@ int cmd_repack(int argc,
* Ok we have prepared all new packfiles.
*/
for_each_string_list_item(item, &names)
generated_pack_install(item->util, item->string);
generated_pack_install(item->util, item->string, packdir,
packtmp);
/* End of pack replacement. */
if (delete_redundant && pack_everything & ALL_INTO_ONE)