do_for_each_ref(): correctly terminate while processesing extra_refs

If the user-supplied function returns a nonzero value while processing
extra_refs, terminate without processing the rest of the list.

This probably has no practical importance, but makes the handling of
extra_refs a little bit more consistent with the handling of other
refs.

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Michael Haggerty
2011-10-19 23:44:46 +02:00
committed by Junio C Hamano
parent 20be917634
commit 7748941eaa

5
refs.c
View File

@@ -706,8 +706,11 @@ static int do_for_each_ref(const char *submodule, const char *base, each_ref_fn
struct ref_array *extra = &extra_refs;
for (i = 0; i < extra->nr; i++)
for (i = 0; i < extra->nr; i++) {
retval = do_one_ref(base, fn, trim, flags, cb_data, extra->refs[i]);
if (retval)
goto end_each;
}
while (p < packed->nr && l < loose->nr) {
struct ref_entry *entry;