global/git
1
0
Fork 0
mirror of https://github.com/git/git.git synced 2026-01-26 02:24:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

git_config_rename_section_in_file(): avoid resource leak

Browse Source 
In case of errors, we really want the file descriptor to be closed.

Discovered by a Coverity scan.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
This commit is contained in:
Johannes Schindelin
2017-04-17 13:18:32 +02:00
parent 84870536b1
commit 775c6ffd87
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
config.c
View File

@@ -2426,7 +2426,7 @@ int git_config_rename_section_in_file(const char *config_filename,
struct lock_file *lock;
int out_fd;
char buf[1024];
FILE *config_file;
FILE *config_file = NULL;
struct stat st;
if (new_name && !section_name_is_ok(new_name)) {
@@ -2508,11 +2508,14 @@ int git_config_rename_section_in_file(const char *config_filename,
}
}
fclose(config_file);
config_file = NULL;
commit_and_out:
if (commit_lock_file(lock) < 0)
ret = error_errno("could not write config file %s",
config_filename);
out:
if (config_file)
fclose(config_file);
rollback_lock_file(lock);
out_no_rollback:
free(filename_buf);