global/git
1
0
Fork 0
mirror of https://github.com/git/git.git synced 2026-01-24 17:41:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

fixup! dir.c: regression fix for add_excludes with fscache

Browse Source 
It is unlikely that the fstat() call fails, but not impossible...
Coverity pointed out that we check for its return value elsewhere, so we
might just as well do it here, too.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
This commit is contained in:
Johannes Schindelin
2017-12-21 14:34:42 +01:00
parent 0d68a457f9
commit 848222cb91
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
dir.c
View File

@@ -788,8 +788,10 @@ static int add_excludes(const char *fname, const char *base, int baselen,
fd = open(fname, O_RDONLY);
if (fd < 0)
warn_on_fopen_errors(fname);
if (S_ISLNK(st.st_mode))
fstat(fd, &st);
if (S_ISLNK(st.st_mode) && fstat(fd, &st) < 0) {
warn_on_fopen_errors(fname);
fd = -1;
}
}
} else {
fd = open(fname, O_RDONLY);