mingw: change core.fsyncObjectFiles = 1 by default

From the documentation of said setting:

	This boolean will enable fsync() when writing object files.

	This is a total waste of time and effort on a filesystem that
	orders data writes properly, but can be useful for filesystems
	that do not use journalling (traditional UNIX filesystems) or
	that only journal metadata and not file contents (OS X’s HFS+,
	or Linux ext3 with "data=writeback").

The most common file system on Windows (NTFS) does not guarantee that
order, therefore a sudden loss of power (or any other event causing an
unclean shutdown) would cause corrupt files (i.e. files filled with
NULs). Therefore we need to change the default.

Note that the documentation makes it sound as if this causes really bad
performance. In reality, writing loose objects is something that is done
only rarely, and only a handful of files at a time.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
This commit is contained in:
Johannes Schindelin
2017-09-04 11:59:45 +02:00
committed by Jameson Miller
parent 4d615d692e
commit 8703120d17

View File

@@ -3114,6 +3114,7 @@ int msc_startup(int argc, wchar_t **w_argv, wchar_t **w_env)
_CrtSetDbgFlag(_CRTDBG_ALLOC_MEM_DF | _CRTDBG_LEAK_CHECK_DF);
#endif
fsync_object_files = 1;
maybe_redirect_std_handles();
/* determine size of argv conversion buffer */
@@ -3180,6 +3181,7 @@ void mingw_startup(void)
wchar_t **wenv, **wargv;
_startupinfo si;
fsync_object_files = 1;
maybe_redirect_std_handles();
/* get wide char arguments and environment */