global/git
1
0
Fork 0
mirror of https://github.com/git/git.git synced 2026-02-02 05:52:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

submodule: fix segmentation fault in submodule--helper clone

Browse Source 
The git submodule--helper clone command will fail with a segmentation
fault when given a null url or null path variable. Since these are
required for proper functioning of the submodule--helper clone
subcommand, add checks to prevent running and fail gracefully when
missing.

Update the usage string to reflect the requirement that the --url and
--path "options" are required.

Signed-off-by: Jacob Keller <jacob.keller@gmail.com>
Reviewed-by: Stefan Beller <sbeller@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
This commit is contained in:
Jacob Keller
2016-02-29 14:58:33 -08:00
committed by Johannes Schindelin
parent a7e254611d
commit 9a237b760e
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
builtin/submodule--helper.c
View File

@@ -515,7 +515,7 @@ static int module_clone(int argc, const char **argv, const char *prefix)
usage_with_options(git_submodule_helper_usage,
module_clone_options);
if (argc)
if (argc || !url)
usage_with_options(git_submodule_helper_usage,
module_clone_options);