global/git
1
0
Fork 0
mirror of https://github.com/git/git.git synced 2026-03-09 16:52:33 +01:00
Code Issues Packages Projects Releases Wiki Activity

send-email: pass smtp hostname and port to Authen::SASL

Browse Source 
Starting from version 2.2000, Authen::SASL supports passing the SMTP
server hostname and port to the OAUTHBEARER string passed via SMTP AUTH.
Add support for the same in git-send-email.

It's safe to add the new parameters unconditionally as older versions of
Authen::SASL will simply ignore them without any error. Something
similar is already being done for the authname parameter, which is not
supported by every authentication mechanism. This can be understood as
declaring a variable but not using at all.

Link: https://metacpan.org/pod/Authen::SASL::Perl::OAUTHBEARER

Signed-off-by: Aditya Garg <gargaditya08@live.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Aditya Garg
2026-03-05 17:01:15 +00:00
committed by Junio C Hamano
parent 795c338de7
commit b10fb23d52
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
git-send-email.perl
View File

@@ -1474,6 +1474,8 @@ sub smtp_auth_maybe {
user => $cred->{'username'},
pass => $cred->{'password'},
authname => $cred->{'username'},
host => $smtp_server,
(defined $smtp_server_port ? (port => $smtp_server_port) : ()),
}
);
$result = $smtp->auth($sasl);