global/git
1
0
Fork 0
mirror of https://github.com/git/git.git synced 2026-03-11 09:29:49 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'jc/doc-wholesale-replace-before-next' into jch

Browse Source 
Doc update.

* jc/doc-wholesale-replace-before-next:
  SubmittingPatches: spell out "replace fully to pretend to be perfect"
This commit is contained in:
Junio C Hamano
2026-03-10 14:24:02 -07:00
parent d9903d45bd 476365ac85
commit cd94ed5f80
1 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
Documentation/SubmittingPatches
View File

@@ -56,6 +56,18 @@ feedback before sending a new version, rather than sending an updated
series immediately after receiving a review. This helps collect broader
input and avoids unnecessary churn from many rapid iterations.
. These early update iterations are expected to be full replacements,
not incremental updates on top of what you posted already. If you
are correcting mistakes you made in the previous iteration that a
reviewer noticed and pointed out in their review, you _fix_ that
mistake by rewriting your history (e.g., by using "git rebase -i")
to pretend that you never made the mistake in the first place. In
other words, this is a chance to pretend to be a perfect developer,
and you are expected to take advantage of that. In the larger
picture, nobody is interested in your earlier mistakes. Just
present a logical progression made by a perfect developer who makes
no mistakes while working on the topic.
. Polish, refine, and re-send your patches to the list and to the people
who spent their time to improve your patch. Go back to step (2).