global/git
1
0
Fork 0
mirror of https://github.com/git/git.git synced 2026-02-26 01:43:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

show-index: warn when falling back to SHA-1 outside a repository

Browse Source 
When 'git show-index' is run outside of a repository and no hashing
algorithm is specified via --object-format, it silently falls back
to SHA-1, relying on the historical default.

This works for existing SHA-1 based index files, but the behavior can
be ambiguous and confusing when the input index file uses a different
hash algorithm, such as SHA-256.

Add a warning when this fallback happens to make the assumption
explicit and to guide users toward using --object-format when needed.

Signed-off-by: Shreyansh Paliwal <shreyanshpaliwalcmsmn@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Shreyansh Paliwal
2026-01-30 21:01:23 +05:30
committed by Junio C Hamano
parent ea717645d1
commit ea39808a22
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
builtin/show-index.c
View File

@@ -43,11 +43,14 @@ int cmd_show_index(int argc,
/*
* Fallback to SHA1 if we are running outside of a repository.
*
* TODO: Figure out and implement a way to detect the hash algorithm in use by the
* the index file passed in and use that instead.
* TODO: If a future implementation of index file version encodes the hash
* algorithm in its header, enable show-index to infer it from the
* header rather than relying on repository context or a default fallback.
*/
if (!the_hash_algo)
if (!the_hash_algo) {
warning(_("assuming SHA-1; use --object-format to override"));
repo_set_hash_algo(the_repository, GIT_HASH_DEFAULT);
}
hashsz = the_hash_algo->rawsz;