Merge pull request #2026 from gitster/kg/external-diff-save-env

diff: ensure correct lifetime of external_diff_cmd
This commit is contained in:
Johannes Schindelin
2019-01-16 10:21:16 +01:00
committed by Johannes Schindelin

2
diff.c
View File

@@ -489,7 +489,7 @@ static const char *external_diff(void)
if (done_preparing)
return external_diff_cmd;
external_diff_cmd = getenv("GIT_EXTERNAL_DIFF");
external_diff_cmd = xstrdup_or_null(getenv("GIT_EXTERNAL_DIFF"));
if (!external_diff_cmd)
external_diff_cmd = external_diff_cmd_cfg;
done_preparing = 1;