global/git
1
0
Fork 0
mirror of https://github.com/git/git.git synced 2026-03-04 22:47:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

fetch: fix wrong evaluation order in URL trailing-slash trimming

Browse Source 
if i == -1, url[i] will be UB.

Signed-off-by: cuiweixie <cuiweixie@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
cuiweixie
2026-02-25 02:00:57 +00:00
committed by Junio C Hamano
parent f368df439b
commit f87593ab1a
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
builtin/fetch.c
View File

@@ -761,7 +761,7 @@ static void display_state_init(struct display_state *display_state, struct ref *
display_state->url = xstrdup("foreign");
display_state->url_len = strlen(display_state->url);
for (i = display_state->url_len - 1; display_state->url[i] == '/' && 0 <= i; i--)
for (i = display_state->url_len - 1; 0 <= i && display_state->url[i] == '/'; i--)
;
display_state->url_len = i + 1;
if (4 < i && !strncmp(".git", display_state->url + i - 3, 4))