global/git
1
0
Fork 0
mirror of https://github.com/git/git.git synced 2026-04-13 18:30:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

sequencer: roll back lock file if write_message() failed

Browse Source 
There is no need to wait until the atexit() handler kicks in at the end.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
This commit is contained in:
Johannes Schindelin
2016-10-21 13:19:25 +02:00
parent c3d24e13d3
commit fad8da54b8
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
sequencer.c
View File

@@ -241,10 +241,14 @@ static int write_message(struct strbuf *msgbuf, const char *filename)
int msg_fd = hold_lock_file_for_update(&msg_file, filename, 0);
if (msg_fd < 0)
return error_errno(_("Could not lock '%s'"), filename);
if (write_in_full(msg_fd, msgbuf->buf, msgbuf->len) < 0)
return error_errno(_("Could not write to %s"), filename);
if (commit_lock_file(&msg_file) < 0)
if (write_in_full(msg_fd, msgbuf->buf, msgbuf->len) < 0) {
rollback_lock_file(&msg_file);
return error_errno(_("Could not write to '%s'"), filename);
}
if (commit_lock_file(&msg_file) < 0) {
rollback_lock_file(&msg_file);
return error(_("Error wrapping up %s."), filename);
}
return 0;
}