Jeff King 0921da1724 check_connected(): fix leak of pack-index mmap
Since c6807a40dc (clone: open a shortcut for connectivity check,
2013-05-26), we may open a one-off packed_git struct to check what's in
the pack we just received. At the end of the function we throw away the
struct (rather than linking it into the repository struct as usual).

We used to leak the struct until dd4143e7bf (connected.c: free the
"struct packed_git", 2022-11-08), which calls free(). But that's not
sufficient; inside the struct we'll have mmap'd the pack idx data from
disk, which needs an munmap() call.

Building with SANITIZE=leak doesn't detect this, because we are leaking
our own mmap(), and it only finds heap allocations from malloc(). But if
we use our compat mmap implementation like this:

  make NO_MMAP=MapsBecomeMallocs SANITIZE=leak

then LSan will notice the leak, because now it's a regular heap buffer
allocated by malloc().

We can fix it by calling close_pack(), which will free any associated
memory. Note that we need to check for NULL ourselves; unlike free(), it
is not safe to pass a NULL pointer to close_pack().

Signed-off-by: Jeff King <peff@peff.net>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2026-03-06 13:51:03 -08:00
2026-01-23 13:34:36 -08:00
2026-01-23 13:34:37 -08:00
2025-12-19 17:57:26 +09:00
2026-01-23 13:34:36 -08:00
2025-08-02 22:44:58 -07:00
2025-07-01 07:46:22 -07:00
2025-10-08 12:17:55 -07:00
2026-01-23 13:34:36 -08:00
2025-10-26 16:34:39 -07:00
2025-12-30 12:58:19 +09:00
2025-12-07 07:28:13 +09:00
2026-01-09 18:36:16 -08:00
2026-01-09 06:37:02 -08:00
2025-09-16 18:00:25 -07:00
2025-09-16 18:00:25 -07:00
2025-12-25 08:29:29 +09:00
2025-12-25 08:29:28 +09:00
2025-07-23 08:15:18 -07:00
2025-12-30 10:53:47 +09:00
2025-03-03 13:49:23 -08:00
2025-11-03 06:49:55 -08:00
2025-09-12 08:59:52 -07:00
2025-12-05 14:49:56 +09:00
2026-02-01 18:15:01 -08:00
2026-01-23 13:34:36 -08:00
2025-07-23 08:15:18 -07:00
2025-12-16 11:08:35 +09:00
2025-05-12 13:06:26 -07:00
2025-11-25 12:15:59 -08:00
2025-11-25 12:15:59 -08:00
2025-07-15 15:18:18 -07:00
2025-11-19 17:41:03 -08:00
2025-11-19 17:41:03 -08:00
2025-07-01 14:58:24 -07:00
2025-07-01 14:46:37 -07:00
2025-08-21 13:46:59 -07:00
2026-01-23 13:34:37 -08:00
2025-11-04 07:48:07 -08:00
2025-08-21 13:46:58 -07:00
2025-11-19 10:55:42 -08:00
2025-12-23 11:33:15 +09:00
2025-07-15 15:18:18 -07:00
2025-07-01 14:58:24 -07:00
2025-12-25 08:29:28 +09:00
2025-12-25 08:29:28 +09:00
2025-12-29 22:02:54 +09:00
2025-03-03 13:49:26 -08:00
2025-07-23 08:15:18 -07:00
2025-03-03 13:49:27 -08:00
2026-01-09 18:36:17 -08:00
2026-01-09 18:36:17 -08:00
2025-12-16 11:08:35 +09:00
2025-12-07 07:28:11 +09:00
2025-11-12 14:04:04 -08:00

Build status

Git - fast, scalable, distributed revision control system

Git is a fast, scalable, distributed revision control system with an unusually rich command set that provides both high-level operations and full access to internals.

Git is an Open Source project covered by the GNU General Public License version 2 (some parts of it are under different licenses, compatible with the GPLv2). It was originally written by Linus Torvalds with help of a group of hackers around the net.

Please read the file INSTALL for installation instructions.

Many Git online resources are accessible from https://git-scm.com/ including full documentation and Git related tools.

See Documentation/gittutorial.adoc to get started, then see Documentation/giteveryday.adoc for a useful minimum set of commands, and Documentation/git-<commandname>.adoc for documentation of each command. If git has been correctly installed, then the tutorial can also be read with man gittutorial or git help tutorial, and the documentation of each command with man git-<commandname> or git help <commandname>.

CVS users may also want to read Documentation/gitcvs-migration.adoc (man gitcvs-migration or git help cvs-migration if git is installed).

The user discussion and development of Git take place on the Git mailing list -- everyone is welcome to post bug reports, feature requests, comments and patches to git@vger.kernel.org (read Documentation/SubmittingPatches for instructions on patch submission and Documentation/CodingGuidelines).

Those wishing to help with error message, usage and informational message string translations (localization l10) should see po/README.md (a po file is a Portable Object file that holds the translations).

To subscribe to the list, send an email to git+subscribe@vger.kernel.org (see https://subspace.kernel.org/subscribing.html for details). The mailing list archives are available at https://lore.kernel.org/git/, https://marc.info/?l=git and other archival sites.

Issues which are security relevant should be disclosed privately to the Git Security mailing list git-security@googlegroups.com.

The maintainer frequently sends the "What's cooking" reports that list the current status of various development topics to the mailing list. The discussion following them give a good reference for project status, development direction and remaining tasks.

The name "git" was given by Linus Torvalds when he wrote the very first version. He described the tool as "the stupid content tracker" and the name as (depending on your mood):

  • random three-letter combination that is pronounceable, and not actually used by any common UNIX command. The fact that it is a mispronunciation of "get" may or may not be relevant.
  • stupid. contemptible and despicable. simple. Take your pick from the dictionary of slang.
  • "global information tracker": you're in a good mood, and it actually works for you. Angels sing, and a light suddenly fills the room.
  • "goddamn idiotic truckload of sh*t": when it breaks
Description
No description provided
Readme 705 MiB
Languages
C 50.5%
Shell 38.8%
Perl 4.4%
Tcl 3.2%
Python 0.8%
Other 2.1%