Joanna Wang 1164c7232e attr: enable attr pathspec magic for git-add and git-stash
Allow users to limit or exclude files based on file attributes
during git-add and git-stash.

For example, the chromium project would like to use

    $ git add . ':(exclude,attr:submodule)'

as submodules are managed by an external tool, forbidding end users
to record changes with "git add".  Allowing "git add" to often
records changes that users do not want in their commits.

This commit does not change any attr magic implementation. It is
only adding attr as an allowed pathspec in git-add and git-stash,
which was previously blocked by GUARD_PATHSPEC and a pathspec mask
in parse_pathspec()).

However, we fix a bug in prefix_magic() where attr values were
unintentionally removed.  This was triggerable when parse_pathspec()
is called with PATHSPEC_PREFIX_ORIGIN as a flag, which was the case
for git-stash (Bug originally filed here [*])

Furthermore, while other commands hit this code path it did not
result in unexpected behavior because this bug only impacts the
pathspec->items->original field which is NOT used to filter
paths. However, git-stash does use pathspec->items->original when
building args used to call other git commands.  (See add_pathspecs()
usage and implementation in stash.c)

It is possible that when the attr pathspec feature was first added
in b0db704652 (pathspec: allow querying for attributes, 2017-03-13),
"PATHSPEC_ATTR" was just unintentionally left out of a few
GUARD_PATHSPEC() invocations.

Later, to get a more user-friendly error message when attr was used
with git-add, PATHSPEC_ATTR was added as a mask to git-add's
invocation of parse_pathspec() 84d938b732 (add: do not accept
pathspec magic 'attr', 2018-09-18).  However, this user-friendly
error message was never added for git-stash.

[Reference]
 * https://lore.kernel.org/git/CAMmZTi-0QKtj7Q=sbC5qhipGsQxJFOY-Qkk1jfkRYwfF5FcUVg@mail.gmail.com/)

Signed-off-by: Joanna Wang <jojwang@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2023-11-04 17:00:27 +09:00
2023-10-12 12:18:27 -07:00
2023-09-07 15:06:08 -07:00
2023-07-06 11:54:48 -07:00
2023-10-30 07:09:55 +09:00
2023-07-25 12:05:24 -07:00
2023-10-23 13:56:36 -07:00
2023-04-24 12:47:33 -07:00
2023-10-30 07:09:55 +09:00
2023-07-06 11:54:48 -07:00
2023-04-10 08:46:40 -07:00
2023-08-31 15:51:07 -07:00
2023-08-31 15:51:07 -07:00
2023-08-31 15:51:07 -07:00
2023-04-24 22:31:32 -07:00
2023-04-17 21:15:56 +02:00
2023-08-30 17:20:31 -07:00
2023-08-24 09:32:34 -07:00
2023-06-28 14:06:39 -07:00
2023-04-17 21:15:44 +02:00
2023-06-28 14:06:39 -07:00
2023-04-17 21:15:49 +02:00
2023-10-23 13:56:37 -07:00
2023-06-21 13:39:54 -07:00
2023-10-09 15:55:01 -07:00
2023-10-09 15:55:01 -07:00
2023-07-06 11:54:48 -07:00
2023-07-06 11:54:46 -07:00
2023-10-23 13:56:36 -07:00
2023-06-28 14:06:39 -07:00
2023-06-12 13:49:36 -07:00
2023-09-25 14:52:34 -07:00
2023-07-25 12:05:24 -07:00
2023-08-24 09:32:34 -07:00
2023-10-02 11:20:00 -07:00
2023-09-19 14:40:19 -07:00
2023-08-29 13:51:44 -07:00
2023-08-29 13:51:44 -07:00
2023-08-29 13:51:44 -07:00
2023-06-28 14:06:39 -07:00
2023-05-17 10:11:41 -07:00

Build status

Git - fast, scalable, distributed revision control system

Git is a fast, scalable, distributed revision control system with an unusually rich command set that provides both high-level operations and full access to internals.

Git is an Open Source project covered by the GNU General Public License version 2 (some parts of it are under different licenses, compatible with the GPLv2). It was originally written by Linus Torvalds with help of a group of hackers around the net.

Please read the file INSTALL for installation instructions.

Many Git online resources are accessible from https://git-scm.com/ including full documentation and Git related tools.

See Documentation/gittutorial.txt to get started, then see Documentation/giteveryday.txt for a useful minimum set of commands, and Documentation/git-<commandname>.txt for documentation of each command. If git has been correctly installed, then the tutorial can also be read with man gittutorial or git help tutorial, and the documentation of each command with man git-<commandname> or git help <commandname>.

CVS users may also want to read Documentation/gitcvs-migration.txt (man gitcvs-migration or git help cvs-migration if git is installed).

The user discussion and development of Git take place on the Git mailing list -- everyone is welcome to post bug reports, feature requests, comments and patches to git@vger.kernel.org (read Documentation/SubmittingPatches for instructions on patch submission and Documentation/CodingGuidelines).

Those wishing to help with error message, usage and informational message string translations (localization l10) should see po/README.md (a po file is a Portable Object file that holds the translations).

To subscribe to the list, send an email with just "subscribe git" in the body to majordomo@vger.kernel.org (not the Git list). The mailing list archives are available at https://lore.kernel.org/git/, http://marc.info/?l=git and other archival sites.

Issues which are security relevant should be disclosed privately to the Git Security mailing list git-security@googlegroups.com.

The maintainer frequently sends the "What's cooking" reports that list the current status of various development topics to the mailing list. The discussion following them give a good reference for project status, development direction and remaining tasks.

The name "git" was given by Linus Torvalds when he wrote the very first version. He described the tool as "the stupid content tracker" and the name as (depending on your mood):

  • random three-letter combination that is pronounceable, and not actually used by any common UNIX command. The fact that it is a mispronunciation of "get" may or may not be relevant.
  • stupid. contemptible and despicable. simple. Take your pick from the dictionary of slang.
  • "global information tracker": you're in a good mood, and it actually works for you. Angels sing, and a light suddenly fills the room.
  • "goddamn idiotic truckload of sh*t": when it breaks
Description
No description provided
Readme 577 MiB
Languages
C 50.4%
Shell 38.7%
Perl 4.4%
Tcl 3.1%
Python 0.8%
Other 2.4%