Patrick Steinhardt 2a00891ccc upload-pack: adapt keepalives based on buffering
The function `create_pack_file()` is responsible for sending the
packfile data to the client of git-upload-pack(1). As generating the
bytes may take significant computing resources we also have a mechanism
in place that optionally sends keepalive pktlines in case we haven't
sent out any data.

The keepalive logic is purely based poll(3p): we pass a timeout to that
syscall, and if the call times out we send out the keepalive pktline.
While reasonable, this logic isn't entirely sufficient: even if the call
to poll(3p) ends because we have received data on any of the file
descriptors we may not necessarily send data to the client.

The most important edge case here happens in `relay_pack_data()`. When
we haven't seen the initial "PACK" signature from git-pack-objects(1)
yet we buffer incoming data. So in the worst case, if each of the bytes
of that signature arrive shortly before the configured keepalive
timeout, then we may not send out any data for a time period that is
(almost) four times as long as the configured timeout.

This edge case is rather unlikely to matter in practice. But in a
subsequent commit we're going to adapt our buffering mechanism to become
more aggressive, which makes it more likely that we don't send any data
for an extended amount of time.

Adapt the logic so that instead of using a fixed timeout on every call
to poll(3p), we instead figure out how much time has passed since the
last-sent data.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2026-03-03 09:52:34 -08:00
2026-01-23 13:34:36 -08:00
2026-01-23 13:34:37 -08:00
2025-12-19 17:57:26 +09:00
2026-01-23 13:34:36 -08:00
2025-08-02 22:44:58 -07:00
2025-07-01 07:46:22 -07:00
2025-10-08 12:17:55 -07:00
2026-01-23 13:34:36 -08:00
2025-10-26 16:34:39 -07:00
2025-12-30 12:58:19 +09:00
2025-12-07 07:28:13 +09:00
2026-01-09 18:36:16 -08:00
2026-01-09 06:37:02 -08:00
2025-09-16 18:00:25 -07:00
2025-09-16 18:00:25 -07:00
2025-12-25 08:29:29 +09:00
2025-12-25 08:29:28 +09:00
2025-07-23 08:15:18 -07:00
2025-12-30 10:53:47 +09:00
2025-11-03 06:49:55 -08:00
2025-09-12 08:59:52 -07:00
2025-12-05 14:49:56 +09:00
2026-02-01 18:15:01 -08:00
2026-01-23 13:34:36 -08:00
2025-07-23 08:15:18 -07:00
2025-12-16 11:08:35 +09:00
2025-05-12 13:06:26 -07:00
2025-11-25 12:15:59 -08:00
2025-11-25 12:15:59 -08:00
2025-07-15 15:18:18 -07:00
2025-11-19 17:41:03 -08:00
2025-11-19 17:41:03 -08:00
2025-07-01 14:58:24 -07:00
2025-07-01 14:46:37 -07:00
2025-08-21 13:46:59 -07:00
2026-01-23 13:34:37 -08:00
2025-11-04 07:48:07 -08:00
2025-08-21 13:46:58 -07:00
2025-11-19 10:55:42 -08:00
2025-12-23 11:33:15 +09:00
2025-07-15 15:18:18 -07:00
2025-07-01 14:58:24 -07:00
2025-12-25 08:29:28 +09:00
2025-12-25 08:29:28 +09:00
2025-12-29 22:02:54 +09:00
2025-07-23 08:15:18 -07:00
2026-01-09 18:36:17 -08:00
2026-01-09 18:36:17 -08:00
2025-12-16 11:08:35 +09:00
2025-12-07 07:28:11 +09:00
2025-11-12 14:04:04 -08:00

Build status

Git - fast, scalable, distributed revision control system

Git is a fast, scalable, distributed revision control system with an unusually rich command set that provides both high-level operations and full access to internals.

Git is an Open Source project covered by the GNU General Public License version 2 (some parts of it are under different licenses, compatible with the GPLv2). It was originally written by Linus Torvalds with help of a group of hackers around the net.

Please read the file INSTALL for installation instructions.

Many Git online resources are accessible from https://git-scm.com/ including full documentation and Git related tools.

See Documentation/gittutorial.adoc to get started, then see Documentation/giteveryday.adoc for a useful minimum set of commands, and Documentation/git-<commandname>.adoc for documentation of each command. If git has been correctly installed, then the tutorial can also be read with man gittutorial or git help tutorial, and the documentation of each command with man git-<commandname> or git help <commandname>.

CVS users may also want to read Documentation/gitcvs-migration.adoc (man gitcvs-migration or git help cvs-migration if git is installed).

The user discussion and development of Git take place on the Git mailing list -- everyone is welcome to post bug reports, feature requests, comments and patches to git@vger.kernel.org (read Documentation/SubmittingPatches for instructions on patch submission and Documentation/CodingGuidelines).

Those wishing to help with error message, usage and informational message string translations (localization l10) should see po/README.md (a po file is a Portable Object file that holds the translations).

To subscribe to the list, send an email to git+subscribe@vger.kernel.org (see https://subspace.kernel.org/subscribing.html for details). The mailing list archives are available at https://lore.kernel.org/git/, https://marc.info/?l=git and other archival sites.

Issues which are security relevant should be disclosed privately to the Git Security mailing list git-security@googlegroups.com.

The maintainer frequently sends the "What's cooking" reports that list the current status of various development topics to the mailing list. The discussion following them give a good reference for project status, development direction and remaining tasks.

The name "git" was given by Linus Torvalds when he wrote the very first version. He described the tool as "the stupid content tracker" and the name as (depending on your mood):

  • random three-letter combination that is pronounceable, and not actually used by any common UNIX command. The fact that it is a mispronunciation of "get" may or may not be relevant.
  • stupid. contemptible and despicable. simple. Take your pick from the dictionary of slang.
  • "global information tracker": you're in a good mood, and it actually works for you. Angels sing, and a light suddenly fills the room.
  • "goddamn idiotic truckload of sh*t": when it breaks
Description
No description provided
Readme 695 MiB
Languages
C 50.5%
Shell 38.8%
Perl 4.4%
Tcl 3.2%
Python 0.8%
Other 2.1%