Thomas Gummerer 51bfb734df http-push: fix construction of hex value from path
The get_oid_hex_from_objpath takes care of creating a oid from a
pathname.  It does this by memcpy'ing the first two bytes of the path to
the "hex" string, then skipping the '/', and then copying the rest of the
path to the "hex" string.  Currently it fails to increase the pointer to
the hex string, so the second memcpy invocation just mashes over what
was copied in the first one, and leaves the last two bytes in the string
uninitialized.

This breaks valgrind in t5540, although the test passes without
valgrind:

==5490== Use of uninitialised value of size 8
==5490==    at 0x13C6B5: hexval (cache.h:1238)
==5490==    by 0x13C6DB: hex2chr (cache.h:1247)
==5490==    by 0x13C734: get_sha1_hex (hex.c:42)
==5490==    by 0x13C78E: get_oid_hex (hex.c:53)
==5490==    by 0x118BDA: get_oid_hex_from_objpath (http-push.c:1023)
==5490==    by 0x118C92: process_ls_object (http-push.c:1038)
==5490==    by 0x118E5B: handle_remote_ls_ctx (http-push.c:1077)
==5490==    by 0x118227: xml_end_tag (http-push.c:815)
==5490==    by 0x50C1448: ??? (in /usr/lib/libexpat.so.1.6.6)
==5490==    by 0x50C221B: ??? (in /usr/lib/libexpat.so.1.6.6)
==5490==    by 0x50BFBF2: ??? (in /usr/lib/libexpat.so.1.6.6)
==5490==    by 0x50C0B24: ??? (in /usr/lib/libexpat.so.1.6.6)
==5490==  Uninitialised value was created by a stack allocation
==5490==    at 0x118B63: get_oid_hex_from_objpath (http-push.c:1012)
==5490==

Fix this by correctly incrementing the pointer to the "hex" variable, so
the first two bytes are left untouched by the memcpy call, and the last
two bytes are correctly initialized.

Signed-off-by: Thomas Gummerer <t.gummerer@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2017-10-04 13:48:35 +09:00
2017-07-17 14:54:53 -07:00
2017-09-22 14:51:37 +09:00
2017-07-10 14:24:36 -07:00
2017-07-06 18:14:44 -07:00
2017-09-22 14:50:02 +09:00
2017-03-24 13:31:01 -07:00
2017-06-27 10:35:49 -07:00
2017-06-24 14:28:41 -07:00
2017-06-24 14:28:41 -07:00
2017-06-24 14:28:41 -07:00
2017-03-13 15:28:54 -07:00
2017-06-24 14:28:41 -07:00
2017-07-31 13:05:15 -07:00
2017-05-25 13:08:23 +09:00
2017-05-08 15:12:57 +09:00
2017-05-08 15:12:57 +09:00
2017-06-24 14:28:41 -07:00
2017-08-03 11:08:10 -07:00
2017-05-29 12:34:43 +09:00
2017-05-02 10:46:41 +09:00
2017-07-17 14:54:56 -07:00
2017-01-25 14:42:37 -08:00
2017-07-17 14:54:56 -07:00
2017-06-22 14:15:20 -07:00
2017-08-04 12:40:37 -07:00
2017-06-24 14:28:41 -07:00
2017-06-24 14:28:41 -07:00
2017-06-19 12:38:44 -07:00
2017-06-22 14:15:21 -07:00
2017-06-24 14:28:41 -07:00
2017-06-24 14:28:41 -07:00
2017-06-24 14:28:41 -07:00
2017-03-31 08:33:56 -07:00
2017-05-29 12:34:43 +09:00
2017-03-31 08:33:56 -07:00
2017-09-22 14:49:24 +09:00
2017-06-24 14:28:41 -07:00
2017-06-24 14:28:41 -07:00
2017-07-12 15:18:23 -07:00
2017-06-24 14:28:41 -07:00
2017-01-30 14:17:00 -08:00
2017-06-24 14:28:41 -07:00
2017-06-24 14:28:41 -07:00
2017-06-27 10:35:49 -07:00
2017-07-17 14:54:56 -07:00
2017-06-24 14:28:41 -07:00
2017-06-24 14:28:41 -07:00
2017-02-08 15:39:55 -08:00
2017-01-30 14:17:00 -08:00
2017-05-29 12:34:43 +09:00
2017-06-24 14:28:41 -07:00
2017-06-30 13:11:54 -07:00
2017-10-04 13:47:16 +09:00
2017-06-27 10:35:49 -07:00
2017-05-29 12:34:43 +09:00
2017-07-17 14:54:56 -07:00
2017-07-17 14:54:56 -07:00
2017-06-27 10:35:49 -07:00
2017-09-22 14:49:24 +09:00
2017-06-24 14:28:41 -07:00
2017-08-02 15:45:20 -07:00
2017-06-27 10:35:49 -07:00
2017-03-31 08:33:56 -07:00
2017-06-13 13:47:09 -07:00
2017-07-12 15:18:23 -07:00
2017-03-31 08:33:56 -07:00
2017-05-22 10:20:46 +09:00
2017-05-22 10:20:46 +09:00
2017-07-12 15:18:23 -07:00
2017-06-24 14:28:41 -07:00
2017-07-17 14:54:56 -07:00
2017-05-29 12:34:43 +09:00
2017-05-29 12:34:43 +09:00
2017-06-24 14:28:41 -07:00
2017-06-24 14:28:41 -07:00
2017-06-24 14:28:41 -07:00
2017-06-24 14:28:41 -07:00
2017-06-24 14:28:41 -07:00
2017-06-24 14:28:41 -07:00

Git - fast, scalable, distributed revision control system

Git is a fast, scalable, distributed revision control system with an unusually rich command set that provides both high-level operations and full access to internals.

Git is an Open Source project covered by the GNU General Public License version 2 (some parts of it are under different licenses, compatible with the GPLv2). It was originally written by Linus Torvalds with help of a group of hackers around the net.

Please read the file INSTALL for installation instructions.

Many Git online resources are accessible from https://git-scm.com/ including full documentation and Git related tools.

See Documentation/gittutorial.txt to get started, then see Documentation/giteveryday.txt for a useful minimum set of commands, and Documentation/git-.txt for documentation of each command. If git has been correctly installed, then the tutorial can also be read with man gittutorial or git help tutorial, and the documentation of each command with man git-<commandname> or git help <commandname>.

CVS users may also want to read Documentation/gitcvs-migration.txt (man gitcvs-migration or git help cvs-migration if git is installed).

The user discussion and development of Git take place on the Git mailing list -- everyone is welcome to post bug reports, feature requests, comments and patches to git@vger.kernel.org (read Documentation/SubmittingPatches for instructions on patch submission). To subscribe to the list, send an email with just "subscribe git" in the body to majordomo@vger.kernel.org. The mailing list archives are available at https://public-inbox.org/git/, http://marc.info/?l=git and other archival sites.

The maintainer frequently sends the "What's cooking" reports that list the current status of various development topics to the mailing list. The discussion following them give a good reference for project status, development direction and remaining tasks.

The name "git" was given by Linus Torvalds when he wrote the very first version. He described the tool as "the stupid content tracker" and the name as (depending on your mood):

  • random three-letter combination that is pronounceable, and not actually used by any common UNIX command. The fact that it is a mispronunciation of "get" may or may not be relevant.
  • stupid. contemptible and despicable. simple. Take your pick from the dictionary of slang.
  • "global information tracker": you're in a good mood, and it actually works for you. Angels sing, and a light suddenly fills the room.
  • "goddamn idiotic truckload of sh*t": when it breaks
Description
No description provided
Readme 645 MiB
Languages
C 50.5%
Shell 38.7%
Perl 4.5%
Tcl 3.2%
Python 0.8%
Other 2.1%