Tim Henigan 860f70f9f4 CodingGuidelines: do not use 'which' in shell scripts ...

During the code review of a recent patch, it was noted that shell scripts
must not use 'which $cmd' to check the availability of the command $cmd.
The output of the command is not machine parseable and its exit code is
not reliable across platforms.

It is better to use 'type' to accomplish this task.

Signed-off-by: Tim Henigan <tim.henigan@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

2012-02-27 15:10:23 -08:00

7.7 KiB

Raw Blame History

View Raw