mirror of
https://github.com/git/git.git
synced 2026-03-13 10:23:30 +01:00
2c74439aff
The Coccinelle tool is an ingrained part of our build infrastructure. It is executed by our CI to detect antipatterns and is used to detect misuses of certain interfaces. It's presence in "contrib/" is thus rather misleading. Promote the configuration into the new "tools/" directory. Signed-off-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Junio C Hamano <gitster@pobox.com>
54 lines
1.0 KiB
Plaintext
54 lines
1.0 KiB
Plaintext
@@
|
|
expression c;
|
|
@@
|
|
- &c->maybe_tree->object.oid
|
|
+ get_commit_tree_oid(c)
|
|
|
|
@@
|
|
expression c;
|
|
@@
|
|
- c->maybe_tree->object.oid.hash
|
|
+ get_commit_tree_oid(c)->hash
|
|
|
|
@@
|
|
identifier f !~ "^set_commit_tree$";
|
|
expression c;
|
|
expression s;
|
|
@@
|
|
f(...) {<...
|
|
- c->maybe_tree = s
|
|
+ set_commit_tree(c, s)
|
|
...>}
|
|
|
|
// These excluded functions must access c->maybe_tree directly.
|
|
// Note that if c->maybe_tree is written somewhere outside of these
|
|
// functions, then the recommended transformation will be bogus with
|
|
// repo_get_commit_tree() on the LHS.
|
|
@@
|
|
identifier f != { repo_get_commit_tree, get_commit_tree_in_graph_one,
|
|
load_tree_for_commit, set_commit_tree, repo_parse_commit_no_graph };
|
|
expression c;
|
|
@@
|
|
f(...) {<...
|
|
- c->maybe_tree
|
|
+ repo_get_commit_tree(specify_the_right_repo_here, c)
|
|
...>}
|
|
|
|
@@
|
|
struct commit *c;
|
|
expression E;
|
|
@@
|
|
(
|
|
- c->generation = E;
|
|
+ commit_graph_data_at(c)->generation = E;
|
|
|
|
|
- c->graph_pos = E;
|
|
+ commit_graph_data_at(c)->graph_pos = E;
|
|
|
|
|
- c->generation
|
|
+ commit_graph_generation(c)
|
|
|
|
|
- c->graph_pos
|
|
+ commit_graph_position(c)
|
|
)
|