Jeff King 9e1947cb48 fsck_tree(): fix shadowed variable
Commit b2f2039c2b (fsck: accept an oid instead of a "struct tree" for
fsck_tree(), 2019-10-18) introduced a new "oid" parameter to
fsck_tree(), and we pass it to the report() function when we find
problems. However, that is shadowed within the tree-walking loop by the
existing "oid" variable which we use to store the oid of each tree
entry. As a result, we may report the wrong oid for some problems we
detect within the loop (the entry oid, instead of the tree oid).

Our tests didn't catch this because they checked only that we found the
expected fsck problem, not that it was attached to the correct object.

Let's rename both variables in the function to avoid confusion. This
makes the diff a little noisy (e.g., all of the report() calls outside
the loop were already correct but need to be touched), but makes sure we
catch all cases and will avoid similar confusion in the future.

And we can update the test to be a bit more specific and catch this
problem.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2021-05-03 14:41:08 +09:00
2021-04-16 13:53:34 -07:00
2021-04-30 13:50:27 +09:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-05-03 14:41:08 +09:00
2021-03-08 09:56:34 -08:00
2021-01-21 15:50:00 -08:00
2020-12-08 15:11:17 -08:00
2021-03-13 16:00:09 -08:00
2021-03-30 14:35:37 -07:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2020-08-11 18:04:11 -07:00
2021-01-23 17:14:07 -08:00
2020-08-10 10:23:57 -07:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-01-25 14:19:19 -08:00
2021-04-02 14:43:14 -07:00
2021-02-17 17:21:40 -08:00
2020-07-06 22:09:13 -07:00
2020-08-24 14:54:31 -07:00
2020-11-12 09:40:06 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-02-25 16:43:30 -08:00
2021-04-16 13:53:33 -07:00
2020-07-30 19:18:06 -07:00
2020-07-28 15:02:17 -07:00
2021-03-13 16:00:09 -08:00
2020-03-24 15:04:43 -07:00
2021-05-03 14:41:08 +09:00
2021-03-26 14:49:41 -07:00
2020-07-30 19:18:06 -07:00
2021-03-22 14:00:23 -07:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-02-22 12:07:40 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-02-17 17:21:40 -08:00
2021-04-08 13:23:25 -07:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-04-08 13:23:25 -07:00
2021-04-08 13:23:25 -07:00
2021-04-08 13:23:25 -07:00
2021-03-13 16:00:09 -08:00
2021-03-22 14:00:24 -07:00
2021-03-22 14:00:24 -07:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2020-03-24 15:04:44 -07:00
2020-03-24 15:04:44 -07:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-02-05 16:40:45 -08:00
2020-12-14 10:21:36 -08:00
2020-10-27 15:09:50 -07:00
2021-03-26 14:49:41 -07:00
2021-03-13 16:00:09 -08:00
2021-02-17 17:21:40 -08:00
2020-04-29 16:15:27 -07:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-04-16 13:53:34 -07:00
2020-07-28 15:02:17 -07:00
2021-03-13 16:00:09 -08:00
2021-04-05 17:30:36 -07:00
2021-04-14 13:47:54 -07:00
2021-04-14 13:47:54 -07:00
2021-03-13 16:00:09 -08:00
2020-07-30 19:18:06 -07:00
2020-07-30 19:18:06 -07:00
2021-03-13 16:00:09 -08:00
2021-01-04 15:23:08 -08:00
2020-07-28 15:02:17 -07:00
2021-04-20 17:23:34 -07:00
2021-03-13 16:00:09 -08:00
2021-02-16 09:41:32 -08:00
2021-03-13 16:00:09 -08:00

Build status

Git - fast, scalable, distributed revision control system

Git is a fast, scalable, distributed revision control system with an unusually rich command set that provides both high-level operations and full access to internals.

Git is an Open Source project covered by the GNU General Public License version 2 (some parts of it are under different licenses, compatible with the GPLv2). It was originally written by Linus Torvalds with help of a group of hackers around the net.

Please read the file INSTALL for installation instructions.

Many Git online resources are accessible from https://git-scm.com/ including full documentation and Git related tools.

See Documentation/gittutorial.txt to get started, then see Documentation/giteveryday.txt for a useful minimum set of commands, and Documentation/git-<commandname>.txt for documentation of each command. If git has been correctly installed, then the tutorial can also be read with man gittutorial or git help tutorial, and the documentation of each command with man git-<commandname> or git help <commandname>.

CVS users may also want to read Documentation/gitcvs-migration.txt (man gitcvs-migration or git help cvs-migration if git is installed).

The user discussion and development of Git take place on the Git mailing list -- everyone is welcome to post bug reports, feature requests, comments and patches to git@vger.kernel.org (read Documentation/SubmittingPatches for instructions on patch submission). To subscribe to the list, send an email with just "subscribe git" in the body to majordomo@vger.kernel.org. The mailing list archives are available at https://lore.kernel.org/git/, http://marc.info/?l=git and other archival sites.

Issues which are security relevant should be disclosed privately to the Git Security mailing list git-security@googlegroups.com.

The maintainer frequently sends the "What's cooking" reports that list the current status of various development topics to the mailing list. The discussion following them give a good reference for project status, development direction and remaining tasks.

The name "git" was given by Linus Torvalds when he wrote the very first version. He described the tool as "the stupid content tracker" and the name as (depending on your mood):

  • random three-letter combination that is pronounceable, and not actually used by any common UNIX command. The fact that it is a mispronunciation of "get" may or may not be relevant.
  • stupid. contemptible and despicable. simple. Take your pick from the dictionary of slang.
  • "global information tracker": you're in a good mood, and it actually works for you. Angels sing, and a light suddenly fills the room.
  • "goddamn idiotic truckload of sh*t": when it breaks
Description
No description provided
Readme 636 MiB
Languages
C 50.4%
Shell 38.8%
Perl 4.4%
Tcl 3.1%
Python 0.8%
Other 2.3%