Jeff King aad1d1c0d5 t/perf/perf-lib: fix assignment of TEST_OUTPUT_DIRECTORY
Using the perf suite's "run" helper in a vanilla build fails like this:

  $ make && (cd t/perf && ./run p0000-perf-lib-sanity.sh)
  === Running 1 tests in this tree ===
  perf 1 - test_perf_default_repo works: 1 2 3 ok
  perf 2 - test_checkout_worktree works: 1 2 3 ok
  ok 3 - test_export works
  perf 4 - export a weird var: 1 2 3 ok
  perf 5 - éḿíẗ ńöń-ÁŚĆÍÍ ćḧáŕáćẗéŕś: 1 2 3 ok
  ok 6 - test_export works with weird vars
  perf 7 - important variables available in subshells: 1 2 3 ok
  perf 8 - test-lib-functions correctly loaded in subshells: 1 2 3 ok
  # passed all 8 test(s)
  1..8
  cannot open test-results/p0000-perf-lib-sanity.subtests: No such file or directory at ./aggregate.perl line 159.

It is trying to aggregate results written into t/perf/test-results, but
the p0000 script did not write anything there.

The "run" script looks in $TEST_OUTPUT_DIRECTORY/test-results, or if
that variable is not set, in test-results in the current working
directory (which should be t/perf itself). It pulls the value of
$TEST_OUTPUT_DIRECTORY from the GIT-BUILD-OPTIONS file.

But that doesn't quite match the setup in perf-lib.sh (which is what
scripts like p0000 use). There we do this at the top of the script:

  TEST_OUTPUT_DIRECTORY=$(pwd)

and then let test-lib.sh append "/test-results" to that. Historically,
that made the vanilla case work: we'd always use t/perf/test-results.
But when $TEST_OUTPUT_DIRECTORY was set, it would break.

Commit 5756ccd181 (t/perf: fix benchmarks with out-of-tree builds,
2025-04-28) fixed that second case by loading GIT-BUILD-OPTIONS
ourselves. But that broke the vanilla case!

Now our setting of $TEST_OUTPUT_DIRECTORY in perf-lib.sh is ignored,
because it is overwritten by GIT-BUILD-OPTIONS. And when test-lib.sh
sees that the output directory is empty, it defaults to t/test-results,
rather than t/perf/test-results.

Nobody seems to have noticed, probably for two reasons:

  1. It only matters if you're trying to aggregate results (like the
     "run" script does). Just running "./p0000-perf-lib-sanity.sh"
     manually still produces useful output; the stored result files are
     just in an unexpected place.

  2. There might be leftover files in t/perf/test-results from previous
     runs (before 5756ccd181). In particular, the ".subtests" files
     don't tend to change, and the lack of that file is what causes it
     to barf completely. So it's possible that the aggregation could
     have been showing stale results that did not match the run that
     just happened.

We can fix it by setting TEST_OUTPUT_DIRECTORY only after we've loaded
GIT-BUILD-OPTIONS, so that we override its value and not the other way
around. And we'll do so only when the variable is not set, which should
retain the fix for that case from 5756ccd181.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2026-01-07 08:56:36 +09:00
2025-11-12 08:17:31 -08:00
2025-11-17 07:35:33 -08:00
2025-10-15 08:10:17 -07:00
2025-08-02 22:44:58 -07:00
2025-10-14 12:56:09 -07:00
2025-07-01 07:46:22 -07:00
2025-10-08 12:17:55 -07:00
2025-10-26 16:34:39 -07:00
2025-07-01 14:46:38 -07:00
2025-09-08 14:54:35 -07:00
2025-07-15 15:18:18 -07:00
2025-09-16 11:37:06 -07:00
2024-09-16 10:46:00 -07:00
2025-09-16 18:00:25 -07:00
2025-09-16 18:00:25 -07:00
2025-08-21 13:46:58 -07:00
2025-08-04 08:10:33 -07:00
2025-08-21 13:46:59 -07:00
2025-07-23 08:15:18 -07:00
2025-01-21 08:44:54 -08:00
2025-01-21 08:44:54 -08:00
2024-12-18 10:44:31 -08:00
2025-03-03 13:49:23 -08:00
2025-11-03 06:49:55 -08:00
2025-09-12 08:59:52 -07:00
2025-07-01 14:46:38 -07:00
2025-10-22 11:38:58 -07:00
2024-10-23 16:16:36 -04:00
2024-10-23 16:16:36 -04:00
2024-10-23 16:16:36 -04:00
2024-09-19 13:46:00 -07:00
2025-11-17 07:35:33 -08:00
2024-12-18 10:44:31 -08:00
2025-05-08 12:36:31 -07:00
2025-07-01 14:46:38 -07:00
2025-10-07 12:25:27 -07:00
2024-10-23 16:16:36 -04:00
2025-07-01 14:46:38 -07:00
2025-07-23 08:15:18 -07:00
2024-12-18 10:44:31 -08:00
2025-07-23 08:15:18 -07:00
2025-08-21 13:46:59 -07:00
2025-10-07 12:25:27 -07:00
2025-09-16 11:37:06 -07:00
2025-10-07 12:25:27 -07:00
2025-05-12 13:06:26 -07:00
2024-10-21 16:05:04 -04:00
2025-07-15 15:18:18 -07:00
2024-12-18 10:44:30 -08:00
2024-12-18 10:44:30 -08:00
2025-07-01 14:58:24 -07:00
2024-12-18 10:44:30 -08:00
2025-07-01 14:46:37 -07:00
2025-08-21 13:46:59 -07:00
2025-10-08 12:17:55 -07:00
2024-09-19 13:46:01 -07:00
2025-11-04 07:48:07 -08:00
2025-08-21 13:46:58 -07:00
2025-08-21 13:46:58 -07:00
2025-10-26 19:48:21 -07:00
2025-06-17 10:44:38 -07:00
2025-06-17 10:44:38 -07:00
2024-09-19 13:46:12 -07:00
2025-07-15 15:18:18 -07:00
2025-07-01 14:58:24 -07:00
2024-12-18 10:44:30 -08:00
2025-08-21 13:46:59 -07:00
2024-09-30 11:23:03 -07:00
2025-07-01 14:46:37 -07:00
2024-12-23 09:32:11 -08:00
2025-07-01 14:46:38 -07:00
2025-03-03 13:49:26 -08:00
2024-12-18 10:44:30 -08:00
2024-12-18 10:44:30 -08:00
2025-07-23 08:15:18 -07:00
2025-03-03 13:49:27 -08:00
2025-07-01 14:46:38 -07:00
2025-02-06 14:56:45 -08:00

Build status

Git - fast, scalable, distributed revision control system

Git is a fast, scalable, distributed revision control system with an unusually rich command set that provides both high-level operations and full access to internals.

Git is an Open Source project covered by the GNU General Public License version 2 (some parts of it are under different licenses, compatible with the GPLv2). It was originally written by Linus Torvalds with help of a group of hackers around the net.

Please read the file INSTALL for installation instructions.

Many Git online resources are accessible from https://git-scm.com/ including full documentation and Git related tools.

See Documentation/gittutorial.adoc to get started, then see Documentation/giteveryday.adoc for a useful minimum set of commands, and Documentation/git-<commandname>.adoc for documentation of each command. If git has been correctly installed, then the tutorial can also be read with man gittutorial or git help tutorial, and the documentation of each command with man git-<commandname> or git help <commandname>.

CVS users may also want to read Documentation/gitcvs-migration.adoc (man gitcvs-migration or git help cvs-migration if git is installed).

The user discussion and development of Git take place on the Git mailing list -- everyone is welcome to post bug reports, feature requests, comments and patches to git@vger.kernel.org (read Documentation/SubmittingPatches for instructions on patch submission and Documentation/CodingGuidelines).

Those wishing to help with error message, usage and informational message string translations (localization l10) should see po/README.md (a po file is a Portable Object file that holds the translations).

To subscribe to the list, send an email to git+subscribe@vger.kernel.org (see https://subspace.kernel.org/subscribing.html for details). The mailing list archives are available at https://lore.kernel.org/git/, https://marc.info/?l=git and other archival sites.

Issues which are security relevant should be disclosed privately to the Git Security mailing list git-security@googlegroups.com.

The maintainer frequently sends the "What's cooking" reports that list the current status of various development topics to the mailing list. The discussion following them give a good reference for project status, development direction and remaining tasks.

The name "git" was given by Linus Torvalds when he wrote the very first version. He described the tool as "the stupid content tracker" and the name as (depending on your mood):

  • random three-letter combination that is pronounceable, and not actually used by any common UNIX command. The fact that it is a mispronunciation of "get" may or may not be relevant.
  • stupid. contemptible and despicable. simple. Take your pick from the dictionary of slang.
  • "global information tracker": you're in a good mood, and it actually works for you. Angels sing, and a light suddenly fills the room.
  • "goddamn idiotic truckload of sh*t": when it breaks
Description
No description provided
Readme 719 MiB
Languages
C 50.5%
Shell 38.9%
Perl 4.4%
Tcl 3.1%
Python 0.8%
Other 2.1%