Rubén Justo bab1f1c394 add-patch: do not print hunks repeatedly
The interactive-patch is a sequential process where, on each step, we
print one hunk from a patch and then ask the user how to proceed.

There is a possibility of repeating a step, for example if the user
enters a non-applicable option, i.e: "s"

    $ git add -p
    diff --git a/add-patch.c b/add-patch.c
    index 52be1ddb15..8fb75e82e2 100644
    --- a/add-patch.c
    +++ b/add-patch.c
    @@ -1394,7 +1394,7 @@ N_("j - leave this hunk undecided, see next undecided hunk\n"
     static int patch_update_file(struct add_p_state *s,
     			     struct file_diff *file_diff)
     {
    -	size_t hunk_index = 0;
    +	size_t hunk_index = 0, prev_hunk_index = -1;
     	ssize_t i, undecided_previous, undecided_next;
     	struct hunk *hunk;
     	char ch;
    (1/4) Stage this hunk [y,n,q,a,d,j,J,g,/,e,p,?]? s
    Sorry, cannot split this hunk
    @@ -1394,7 +1394,7 @@ N_("j - leave this hunk undecided, see next undecided hunk\n"
     static int patch_update_file(struct add_p_state *s,
     			     struct file_diff *file_diff)
     {
    -	size_t hunk_index = 0;
    +	size_t hunk_index = 0, prev_hunk_index = -1;
     	ssize_t i, undecided_previous, undecided_next;
     	struct hunk *hunk;
     	char ch;
    (1/4) Stage this hunk [y,n,q,a,d,j,J,g,/,e,p,?]?

... or an invalid option, i.e: "U"

    $ git add -p
    diff --git a/add-patch.c b/add-patch.c
    index 52be1ddb15..8fb75e82e2 100644
    --- a/add-patch.c
    +++ b/add-patch.c
    @@ -1394,7 +1394,7 @@ N_("j - leave this hunk undecided, see next undecided hunk\n"
     static int patch_update_file(struct add_p_state *s,
     			     struct file_diff *file_diff)
     {
    -	size_t hunk_index = 0;
    +	size_t hunk_index = 0, prev_hunk_index = -1;
     	ssize_t i, undecided_previous, undecided_next;
     	struct hunk *hunk;
     	char ch;
    (1/4) Stage this hunk [y,n,q,a,d,j,J,g,/,e,p,?]? U
    y - stage this hunk
    n - do not stage this hunk
    q - quit; do not stage this hunk or any of the remaining ones
    a - stage this hunk and all later hunks in the file
    d - do not stage this hunk or any of the later hunks in the file
    j - leave this hunk undecided, see next undecided hunk
    J - leave this hunk undecided, see next hunk
    g - select a hunk to go to
    / - search for a hunk matching the given regex
    e - manually edit the current hunk
    p - print again the current hunk
    ? - print help
    @@ -1394,7 +1394,7 @@ N_("j - leave this hunk undecided, see next undecided hunk\n"
     static int patch_update_file(struct add_p_state *s,
     			     struct file_diff *file_diff)
     {
    -	size_t hunk_index = 0;
    +	size_t hunk_index = 0, prev_hunk_index = -1;
     	ssize_t i, undecided_previous, undecided_next;
     	struct hunk *hunk;
     	char ch;
    (1/4) Stage this hunk [y,n,q,a,d,j,J,g,/,e,p,?]?

Printing the chunk again followed by the question can be confusing as
the user has to pay special attention to notice that the same chunk is
being reconsidered.

It can also be problematic if the chunk is longer than one screen height
because the result of the previous iteration is lost off the screen (the
help guide in the previous example).

To avoid such problems, stop printing the chunk if the iteration does
not advance to a different chunk.

Signed-off-by: Rubén Justo <rjusto@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2024-03-29 10:12:39 -07:00
2023-12-14 14:38:07 -08:00
2023-11-26 10:07:05 +09:00
2024-02-18 21:03:43 +08:00
2023-11-26 10:07:06 +09:00
2023-11-26 10:10:48 +09:00
2024-02-27 16:04:31 -08:00
2024-02-12 09:32:41 -08:00
2023-12-26 12:04:32 -08:00
2023-12-26 12:04:32 -08:00
2024-03-05 13:04:26 -08:00
2023-11-26 10:10:48 +09:00
2023-07-25 12:05:24 -07:00
2024-01-23 10:40:10 -08:00
2023-11-26 10:10:48 +09:00
2024-03-06 08:10:58 -08:00
2023-07-06 11:54:48 -07:00
2024-02-12 09:32:41 -08:00
2023-04-10 08:46:40 -07:00
2024-02-15 15:14:48 -08:00
2024-03-07 15:59:40 -08:00
2023-08-31 15:51:07 -07:00
2023-04-17 21:15:56 +02:00
2023-11-26 10:07:05 +09:00
2024-03-05 09:44:44 -08:00
2023-11-26 10:07:05 +09:00
2023-06-28 14:06:39 -07:00
2023-12-26 12:04:32 -08:00
2023-06-28 14:06:39 -07:00
2023-11-26 10:07:05 +09:00
2023-11-26 10:07:05 +09:00
2023-11-26 10:07:05 +09:00
2023-11-26 10:07:05 +09:00
2024-02-26 18:10:23 -08:00
2024-02-26 09:35:40 -08:00
2024-02-26 09:35:40 -08:00
2024-02-26 18:10:24 -08:00
2023-06-21 13:39:54 -07:00
2024-03-07 15:59:41 -08:00
2023-12-14 14:38:08 -08:00
2024-02-26 15:34:01 -08:00
2024-02-26 15:34:01 -08:00
2023-06-28 14:06:39 -07:00
2024-02-07 08:28:37 -08:00
2024-02-07 08:28:37 -08:00
2023-11-26 10:07:05 +09:00
2023-09-15 17:08:46 -07:00
2024-01-08 14:05:15 -08:00
2024-03-14 14:05:24 -07:00
2024-03-05 09:44:44 -08:00
2024-03-05 09:44:44 -08:00
2024-02-26 18:10:25 -08:00
2024-03-07 15:59:41 -08:00
2024-03-21 14:55:13 -07:00
2023-11-26 10:07:05 +09:00
2024-03-02 11:12:16 -08:00
2023-12-27 14:52:24 -08:00
2023-09-15 17:08:46 -07:00
2023-11-26 10:07:05 +09:00
2023-03-17 14:03:09 -07:00
2024-03-14 14:05:24 -07:00
2023-06-28 14:06:39 -07:00
2023-11-26 10:07:05 +09:00
2023-11-26 10:07:05 +09:00
2023-04-04 14:28:27 -07:00
2023-05-17 10:11:41 -07:00

Build status

Git - fast, scalable, distributed revision control system

Git is a fast, scalable, distributed revision control system with an unusually rich command set that provides both high-level operations and full access to internals.

Git is an Open Source project covered by the GNU General Public License version 2 (some parts of it are under different licenses, compatible with the GPLv2). It was originally written by Linus Torvalds with help of a group of hackers around the net.

Please read the file INSTALL for installation instructions.

Many Git online resources are accessible from https://git-scm.com/ including full documentation and Git related tools.

See Documentation/gittutorial.txt to get started, then see Documentation/giteveryday.txt for a useful minimum set of commands, and Documentation/git-<commandname>.txt for documentation of each command. If git has been correctly installed, then the tutorial can also be read with man gittutorial or git help tutorial, and the documentation of each command with man git-<commandname> or git help <commandname>.

CVS users may also want to read Documentation/gitcvs-migration.txt (man gitcvs-migration or git help cvs-migration if git is installed).

The user discussion and development of Git take place on the Git mailing list -- everyone is welcome to post bug reports, feature requests, comments and patches to git@vger.kernel.org (read Documentation/SubmittingPatches for instructions on patch submission and Documentation/CodingGuidelines).

Those wishing to help with error message, usage and informational message string translations (localization l10) should see po/README.md (a po file is a Portable Object file that holds the translations).

To subscribe to the list, send an email to git+subscribe@vger.kernel.org (see https://subspace.kernel.org/subscribing.html for details). The mailing list archives are available at https://lore.kernel.org/git/, https://marc.info/?l=git and other archival sites.

Issues which are security relevant should be disclosed privately to the Git Security mailing list git-security@googlegroups.com.

The maintainer frequently sends the "What's cooking" reports that list the current status of various development topics to the mailing list. The discussion following them give a good reference for project status, development direction and remaining tasks.

The name "git" was given by Linus Torvalds when he wrote the very first version. He described the tool as "the stupid content tracker" and the name as (depending on your mood):

  • random three-letter combination that is pronounceable, and not actually used by any common UNIX command. The fact that it is a mispronunciation of "get" may or may not be relevant.
  • stupid. contemptible and despicable. simple. Take your pick from the dictionary of slang.
  • "global information tracker": you're in a good mood, and it actually works for you. Angels sing, and a light suddenly fills the room.
  • "goddamn idiotic truckload of sh*t": when it breaks
Description
No description provided
Readme 557 MiB
Languages
C 50.4%
Shell 38.7%
Perl 4.4%
Tcl 3.1%
Python 0.8%
Other 2.4%