Patrick Steinhardt ceb96a160b midx: fix segfault with no packs and invalid preferred pack
When asked to write a multi-pack-index the user can specify a preferred
pack that is used as a tie breaker when multiple packs contain the same
objects. When this packfile cannot be found, we just pick the first pack
that is getting tracked by the newly written multi-pack-index as a
fallback.

Picking the fallback can fail in the case where we're asked to write a
multi-pack-index with no packfiles at all: picking the fallback value
will cause a segfault as we blindly index into the array of packfiles,
which would be empty.

Fix this bug by resetting the preferred packfile index to `-1` before
searching for the preferred pack. This fixes the segfault as we already
check for whether the index is `> - 1`. If it is not, we simply don't
pick a preferred packfile at all.

Helped-by: Taylor Blau <me@ttaylorr.com>
Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2023-04-14 10:27:51 -07:00
2022-10-07 17:19:59 -07:00
2022-07-10 14:43:34 -07:00
2023-02-27 10:08:57 -08:00
2023-02-18 09:29:13 -08:00
2023-01-23 13:39:51 -08:00
2022-08-03 13:36:09 -07:00
2023-02-15 17:11:52 -08:00
2023-02-22 14:55:45 -08:00
2022-10-30 21:04:44 -04:00
2023-01-09 13:28:36 +09:00
2023-01-09 13:28:36 +09:00
2023-01-08 10:28:34 +09:00
2023-01-02 21:37:18 +09:00
2022-07-19 12:45:31 -07:00
2023-02-27 10:08:56 -08:00
2023-02-27 10:08:56 -08:00
2023-01-16 12:07:47 -08:00
2022-03-28 10:25:52 -07:00
2023-03-12 14:34:41 -07:00
2023-02-24 11:32:29 -08:00
2023-02-22 14:55:45 -08:00
2023-02-06 09:38:31 +01:00
2023-02-06 09:43:39 +01:00
2023-02-06 09:43:28 +01:00
2022-04-06 15:21:59 -07:00
2022-05-02 09:50:37 -07:00
2022-09-14 12:56:39 -07:00
2022-09-14 12:56:39 -07:00
2022-12-15 09:09:38 +09:00
2023-01-09 13:28:36 +09:00
2022-10-30 21:04:41 -04:00
2022-08-29 14:55:11 -07:00
2022-08-22 15:08:30 -07:00
2022-12-13 21:23:36 +09:00
2023-02-15 17:11:53 -08:00
2023-02-14 14:15:57 -08:00
2023-02-06 09:43:28 +01:00
2022-12-01 18:38:07 +09:00
2022-10-30 14:04:51 -04:00
2022-08-30 14:16:49 -07:00
2022-10-24 12:45:26 -07:00
2022-10-24 12:45:26 -07:00
2023-01-02 21:37:18 +09:00
2022-12-13 21:09:40 +09:00
2022-12-13 21:09:40 +09:00
2022-05-02 09:50:37 -07:00
2023-01-23 13:39:51 -08:00
2022-12-26 11:42:05 +09:00

Build status

Git - fast, scalable, distributed revision control system

Git is a fast, scalable, distributed revision control system with an unusually rich command set that provides both high-level operations and full access to internals.

Git is an Open Source project covered by the GNU General Public License version 2 (some parts of it are under different licenses, compatible with the GPLv2). It was originally written by Linus Torvalds with help of a group of hackers around the net.

Please read the file INSTALL for installation instructions.

Many Git online resources are accessible from https://git-scm.com/ including full documentation and Git related tools.

See Documentation/gittutorial.txt to get started, then see Documentation/giteveryday.txt for a useful minimum set of commands, and Documentation/git-<commandname>.txt for documentation of each command. If git has been correctly installed, then the tutorial can also be read with man gittutorial or git help tutorial, and the documentation of each command with man git-<commandname> or git help <commandname>.

CVS users may also want to read Documentation/gitcvs-migration.txt (man gitcvs-migration or git help cvs-migration if git is installed).

The user discussion and development of Git take place on the Git mailing list -- everyone is welcome to post bug reports, feature requests, comments and patches to git@vger.kernel.org (read Documentation/SubmittingPatches for instructions on patch submission and Documentation/CodingGuidelines).

Those wishing to help with error message, usage and informational message string translations (localization l10) should see po/README.md (a po file is a Portable Object file that holds the translations).

To subscribe to the list, send an email with just "subscribe git" in the body to majordomo@vger.kernel.org (not the Git list). The mailing list archives are available at https://lore.kernel.org/git/, http://marc.info/?l=git and other archival sites.

Issues which are security relevant should be disclosed privately to the Git Security mailing list git-security@googlegroups.com.

The maintainer frequently sends the "What's cooking" reports that list the current status of various development topics to the mailing list. The discussion following them give a good reference for project status, development direction and remaining tasks.

The name "git" was given by Linus Torvalds when he wrote the very first version. He described the tool as "the stupid content tracker" and the name as (depending on your mood):

  • random three-letter combination that is pronounceable, and not actually used by any common UNIX command. The fact that it is a mispronunciation of "get" may or may not be relevant.
  • stupid. contemptible and despicable. simple. Take your pick from the dictionary of slang.
  • "global information tracker": you're in a good mood, and it actually works for you. Angels sing, and a light suddenly fills the room.
  • "goddamn idiotic truckload of sh*t": when it breaks
Description
No description provided
Readme 821 MiB
Languages
C 50.4%
Shell 38.8%
Perl 4.4%
Tcl 3.1%
Python 0.8%
Other 2.3%