Jeff King e7ac344d70 unpack_loose_header(): report headers without NUL as "bad"
If a caller asks us to read the whole loose object header value into a
strbuf (e.g., via "cat-file --allow-unknown-type"), we'll keep reading
until we see a NUL byte marking the end of the header.

If we hit Z_STREAM_END before seeing the NUL, we obviously have to stop.
But we return ULHR_TOO_LONG, which doesn't make any sense. The "too
long" return code is used in the normal, 32-byte limited mode to
indicate that we stopped looking. There is no such thing as "too long"
here, as we'd keep reading forever until we see the end of stream or the
NUL.

Instead, we should return ULHR_BAD. The loose object has no NUL marking
the end of header, so it is malformed. The behavior difference is
slight; in either case we'd consider the object unreadable and refuse to
go further. The only difference is the specific error message we
produce.

There's no test case here, as we'd need to generate a valid zlib stream
without a NUL. That's not something Git will do without writing new
custom code. And in the next patch we'll fix another bug in this area
which will make this easier to do (and we will test it then).

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2025-02-25 10:24:54 -08:00
2024-11-26 22:14:59 +01:00
2024-11-26 22:14:59 +01:00
2024-02-14 15:36:06 -08:00
2024-11-26 22:15:00 +01:00
2023-12-14 14:38:07 -08:00
2023-11-26 10:07:05 +09:00
2024-02-18 21:03:43 +08:00
2023-11-26 10:07:06 +09:00
2024-11-26 22:14:59 +01:00
2023-11-26 10:10:48 +09:00
2024-01-18 11:53:17 -08:00
2023-12-26 12:04:32 -08:00
2023-12-26 12:04:32 -08:00
2023-11-26 10:10:48 +09:00
2023-07-25 12:05:24 -07:00
2024-01-23 10:40:10 -08:00
2023-11-26 10:10:48 +09:00
2023-07-06 11:54:48 -07:00
2024-11-26 22:14:59 +01:00
2024-11-26 22:14:58 +01:00
2023-04-10 08:46:40 -07:00
2024-01-08 14:05:15 -08:00
2024-02-15 15:14:48 -08:00
2024-04-19 12:38:54 +02:00
2024-04-19 12:38:50 +02:00
2024-04-19 12:38:50 +02:00
2023-08-31 15:51:07 -07:00
2023-04-17 21:15:56 +02:00
2023-11-26 10:07:05 +09:00
2024-11-26 22:15:00 +01:00
2023-11-26 10:10:48 +09:00
2023-11-26 10:07:05 +09:00
2023-06-28 14:06:39 -07:00
2024-04-19 12:38:50 +02:00
2023-12-26 12:04:32 -08:00
2023-06-28 14:06:39 -07:00
2024-04-19 12:38:50 +02:00
2023-11-26 10:07:05 +09:00
2023-11-26 10:07:05 +09:00
2023-11-26 10:07:05 +09:00
2023-11-26 10:07:05 +09:00
2023-06-21 13:39:54 -07:00
2023-12-14 14:38:08 -08:00
2023-06-28 14:06:39 -07:00
2024-04-19 12:38:54 +02:00
2024-04-19 12:38:46 +02:00
2023-11-26 10:07:05 +09:00
2023-09-15 17:08:46 -07:00
2024-04-19 12:38:54 +02:00
2024-01-08 14:05:15 -08:00
2024-11-26 22:15:00 +01:00
2024-04-19 12:38:54 +02:00
2024-01-08 14:05:15 -08:00
2024-04-19 12:38:54 +02:00
2024-04-19 12:38:54 +02:00
2024-04-19 12:38:54 +02:00
2023-11-26 10:07:05 +09:00
2023-12-27 14:52:24 -08:00
2023-09-15 17:08:46 -07:00
2024-11-26 22:14:59 +01:00
2024-11-26 22:14:59 +01:00
2024-04-19 12:38:50 +02:00
2024-04-19 12:38:37 +02:00
2023-11-26 10:07:05 +09:00
2023-03-17 14:03:09 -07:00
2023-06-28 14:06:39 -07:00
2023-11-26 10:07:05 +09:00
2023-11-26 10:07:05 +09:00
2023-04-04 14:28:27 -07:00
2023-05-17 10:11:41 -07:00

Build status

Git - fast, scalable, distributed revision control system

Git is a fast, scalable, distributed revision control system with an unusually rich command set that provides both high-level operations and full access to internals.

Git is an Open Source project covered by the GNU General Public License version 2 (some parts of it are under different licenses, compatible with the GPLv2). It was originally written by Linus Torvalds with help of a group of hackers around the net.

Please read the file INSTALL for installation instructions.

Many Git online resources are accessible from https://git-scm.com/ including full documentation and Git related tools.

See Documentation/gittutorial.txt to get started, then see Documentation/giteveryday.txt for a useful minimum set of commands, and Documentation/git-<commandname>.txt for documentation of each command. If git has been correctly installed, then the tutorial can also be read with man gittutorial or git help tutorial, and the documentation of each command with man git-<commandname> or git help <commandname>.

CVS users may also want to read Documentation/gitcvs-migration.txt (man gitcvs-migration or git help cvs-migration if git is installed).

The user discussion and development of Git take place on the Git mailing list -- everyone is welcome to post bug reports, feature requests, comments and patches to git@vger.kernel.org (read Documentation/SubmittingPatches for instructions on patch submission and Documentation/CodingGuidelines).

Those wishing to help with error message, usage and informational message string translations (localization l10) should see po/README.md (a po file is a Portable Object file that holds the translations).

To subscribe to the list, send an email to git+subscribe@vger.kernel.org (see https://subspace.kernel.org/subscribing.html for details). The mailing list archives are available at https://lore.kernel.org/git/, https://marc.info/?l=git and other archival sites.

Issues which are security relevant should be disclosed privately to the Git Security mailing list git-security@googlegroups.com.

The maintainer frequently sends the "What's cooking" reports that list the current status of various development topics to the mailing list. The discussion following them give a good reference for project status, development direction and remaining tasks.

The name "git" was given by Linus Torvalds when he wrote the very first version. He described the tool as "the stupid content tracker" and the name as (depending on your mood):

  • random three-letter combination that is pronounceable, and not actually used by any common UNIX command. The fact that it is a mispronunciation of "get" may or may not be relevant.
  • stupid. contemptible and despicable. simple. Take your pick from the dictionary of slang.
  • "global information tracker": you're in a good mood, and it actually works for you. Angels sing, and a light suddenly fills the room.
  • "goddamn idiotic truckload of sh*t": when it breaks
Description
No description provided
Readme 700 MiB
Languages
C 50.5%
Shell 38.8%
Perl 4.4%
Tcl 3.2%
Python 0.8%
Other 2.1%