global/git
1
0
Fork 0
mirror of https://github.com/git/git.git synced 2026-03-13 18:33:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix fstat() implementation for pipes and sockets again.

Browse Source 
It turns out that GetFileInformationByHandle() succeeds even for pipes
and sockets. Hence, we fall back to Windows's own fstat() implementation
for everything except files. This also takes care of any error codes
(again, except for files - but we don't expect any errors here).
This commit is contained in:
Johannes Sixt
2007-09-25 12:32:27 +02:00
parent b0eef9af24
commit 56dc8fc47a
1 changed files with 6 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
compat/mingw.c
View File

@@ -116,17 +116,20 @@ int git_lstat(const char *file_name, struct stat *buf)
return do_lstat(alt_name, buf);
}
#undef fstat
int git_fstat(int fd, struct stat *buf)
{
HANDLE fh = (HANDLE)_get_osfhandle(fd);
BY_HANDLE_FILE_INFORMATION fdata;
char dummy[sizeof(void*)];
int s = sizeof(void*);
if (fh == INVALID_HANDLE_VALUE) {
errno = EBADF;
return -1;
}
/* direct non-file handles to MS's fstat() */
if (GetFileType(fh) != FILE_TYPE_DISK)
return fstat(fd, buf);
if (GetFileInformationByHandle(fh, &fdata)) {
int fMode = S_IREAD;
if (fdata.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY)
@@ -148,22 +151,7 @@ int git_fstat(int fd, struct stat *buf)
buf->st_ctime = filetime_to_time_t(&(fdata.ftCreationTime));
return 0;
}
switch (GetLastError()) {
case ERROR_INVALID_FUNCTION:
/* check for socket */
if (getsockopt((int)fh, SOL_SOCKET, SO_KEEPALIVE, dummy, &s) &&
WSAGetLastError() == WSAENOTSOCK)
goto badf;
memset(buf, sizeof(*buf), 0);
buf->st_mode = S_IREAD|S_IWRITE;
buf->st_mode |= 0x140000; /* S_IFSOCK */
return 0;
default:
case ERROR_INVALID_HANDLE:
badf:
errno = EBADF;
break;
}
errno = EBADF;
return -1;
}